Skip to content

Fixed console scrolling for active console #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akirilov merged 2 commits into from
Nov 8, 2025
Merged

Fixed console scrolling for active console #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9daea10
Fixed console scrolling for active console
akirilov Nov 8, 2025
511d474
Remove duplicate scroll
akirilov Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions UIMod/onboard_bundled/assets/js/console-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ function handleConsole() {

commandContainer.append(prompt, input, suggestions);
consoleElement.appendChild(commandContainer);
consoleElement.scrollTop = consoleElement.scrollHeight;
} catch (error) {
console.error('Error checking SSCM enabled status:', error);
return; // Exit on error
Expand All @@ -176,10 +177,8 @@ function handleConsole() {
const message = document.createElement('div');
message.textContent = event.data;
consoleElement.insertBefore(message, consoleElement.querySelector('.sscm-command-container')); // Insert before input
// Auto-scroll only if at bottom
if (consoleElement.scrollTop + consoleElement.clientHeight >= consoleElement.scrollHeight - 10) {
consoleElement.scrollTop = consoleElement.scrollHeight;
}
// Auto-scroll
consoleElement.scrollTop = consoleElement.scrollHeight;
};

outputEventSource.onopen = () => {
Expand Down
6 changes: 1 addition & 5 deletions UIMod/onboard_bundled/assets/js/sscm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,11 @@ function appendToConsole(message) {

if (commandContainer) {
consoleDiv.insertBefore(messageElement, commandContainer); // Insert before input
consoleDiv.scrollTop = consoleDiv.scrollHeight;
} else {
console.log("SSCM failed to insert command box");
return
}

// Auto-scroll only if at bottom
if (consoleDiv.scrollTop + consoleDiv.clientHeight >= consoleDiv.scrollHeight - 10) {
consoleDiv.scrollTop = consoleDiv.scrollHeight;
}
}

// Enhanced autocomplete functionality
Expand Down