Skip to content

Fixed console scrolling for active console - #140

Merged
akirilov merged 2 commits into
nightlyfrom
fix-console-scroll
Nov 8, 2025
Merged

Fixed console scrolling for active console#140
akirilov merged 2 commits into
nightlyfrom
fix-console-scroll

Conversation

@akirilov

@akirilov akirilov commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

Bugfixes:

  • Active console now scrolls properly

@akirilov
akirilov requested a review from Copilot November 8, 2025 05:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request simplifies the auto-scroll behavior in the console by removing conditional checks and ensuring the console always scrolls to the bottom when new content is added.

  • Removed conditional auto-scroll logic that only scrolled when near the bottom
  • Changed to unconditional auto-scroll for all new console messages
  • Added auto-scroll when the SSCM command container is created

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
UIMod/onboard_bundled/assets/js/sscm.js Simplified scroll behavior in appendToConsole by removing the proximity check and always scrolling to bottom
UIMod/onboard_bundled/assets/js/console-manager.js Removed conditional scroll logic in message handler and added scroll when command input is created

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread UIMod/onboard_bundled/assets/js/sscm.js Outdated
@akirilov
akirilov merged commit 4dd10d4 into nightly Nov 8, 2025
1 check passed
@JacksonTheMaster
JacksonTheMaster deleted the fix-console-scroll branch November 15, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants