Fixed console scrolling for active console - #140
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request simplifies the auto-scroll behavior in the console by removing conditional checks and ensuring the console always scrolls to the bottom when new content is added.
- Removed conditional auto-scroll logic that only scrolled when near the bottom
- Changed to unconditional auto-scroll for all new console messages
- Added auto-scroll when the SSCM command container is created
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| UIMod/onboard_bundled/assets/js/sscm.js | Simplified scroll behavior in appendToConsole by removing the proximity check and always scrolling to bottom |
| UIMod/onboard_bundled/assets/js/console-manager.js | Removed conditional scroll logic in message handler and added scroll when command input is created |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixes: