Skip to content

refactor: delete legacy leftovers with no callers - #303

Merged
luca-belli merged 2 commits into
release/2.1from
refactor/delete-legacy-leftovers
Oct 27, 2026
Merged

luca-belli merged 2 commits into
release/2.1from
refactor/delete-legacy-leftovers

Conversation

@luca-belli

Copy link
Copy Markdown
Collaborator

Roadmap phase 1(a) (#294): delete code with no callers, left over from the legacy scripts.

  • `judge_single_conversation` (and its export and integration test, whose docstring already called it dead)
  • `build_single_conversation_judge_run_key` (and its test, and its exemption in the clock-read guard)
  • `get_judge_logs_root` and the legacy branch of `build_judge_task_log_path`: `output_folder` is now required; `run_key` / `logs_root` and the `VERA_JUDGE_LOGS_ROOT` test setup are gone
  • `ConversationRunner._create_conversation_jobs` (no callers)

The parameters every caller passes the same value for (`run_id`, `persona_names`, `verbose`) are not removed here: phase 1(b) and (c) rewrite those signatures, so they go there (roadmap update in #296).

Independent of the Role stack (#298, #299, #301): no shared files.

Checks

  • ruff clean; pyright adds no errors
  • full-run check on the committed 10-conversation slice: matches the baseline

🤖 Generated with Claude Code

judge_single_conversation, build_single_conversation_judge_run_key,
get_judge_logs_root and the legacy judge log-path branch, and
ConversationRunner._create_conversation_jobs. build_judge_task_log_path
now requires output_folder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@luca-belli
luca-belli requested a review from a team as a code owner October 27, 2026 23:35
@luca-belli
luca-belli requested a balanced review from Copilot October 27, 2026 23:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An [Unreleased] migration entry is still needed for the removed judge_single_conversation export and changed build_judge_task_log_path signature, which alter Python import and call contracts.

1 open issue
What changed in this PR

Removes unused legacy generation and judging code as roadmap phase 1(a), ahead of the planned entry-point simplifications. Active CLI behavior is intended to remain unchanged.

Changes:

  • Deletes unused single-conversation judging helpers, their export, and the generation job builder.
  • Requires output_folder for judge task logs and removes the legacy log layout.
  • Removes obsolete tests and test setup, and updates logging comments.
File Description
tests/​unit/​utils/​test_run_root.py Removes the deleted helper’s clock-read exemption.
tests/​unit/​judge/​test_utils.py Removes tests for the deleted run-key helper.
tests/​unit/​judge/​test_runner_extra_params.py Removes legacy log-layout tests; retains output-folder coverage.
tests/​integration/​test_evaluation_runner.py Removes the unused single-conversation judging test and import.
tests/​conftest.py Removes legacy judge-log temporary-directory setup.
src/​vera_mh/​judge/​utils.py Deletes legacy helpers and requires an output folder for logs.
src/​vera_mh/​judge/​runner.py Deletes judge_single_conversation.
src/​vera_mh/​judge/​llm_judge.py Updates comments to reflect current logging behavior.
src/​vera_mh/​judge/​__init__.py Removes the deleted judging function’s export.
src/​vera_mh/​generate/​runner.py Deletes the unused conversation job builder.

Review effort: Balanced

judge_conversations,
judge_single_conversation,
)
from .runner import judge_conversations
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@luca-belli
luca-belli merged commit 67478e4 into release/2.1 Oct 27, 2026
3 checks passed
@luca-belli
luca-belli deleted the refactor/delete-legacy-leftovers branch October 27, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants