Repository navigation
refactor: delete legacy leftovers with no callers - #303
Merged
Merged
Conversation
judge_single_conversation, build_single_conversation_judge_run_key, get_judge_logs_root and the legacy judge log-path branch, and ConversationRunner._create_conversation_jobs. build_judge_task_log_path now requires output_folder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An [Unreleased] migration entry is still needed for the removed judge_single_conversation export and changed build_judge_task_log_path signature, which alter Python import and call contracts.
1 open issue
What changed in this PR
Removes unused legacy generation and judging code as roadmap phase 1(a), ahead of the planned entry-point simplifications. Active CLI behavior is intended to remain unchanged.
Changes:
- Deletes unused single-conversation judging helpers, their export, and the generation job builder.
- Requires
output_folderfor judge task logs and removes the legacy log layout. - Removes obsolete tests and test setup, and updates logging comments.
| File | Description |
|---|---|
tests/unit/utils/test_run_root.py |
Removes the deleted helper’s clock-read exemption. |
tests/unit/judge/test_utils.py |
Removes tests for the deleted run-key helper. |
tests/unit/judge/test_runner_extra_params.py |
Removes legacy log-layout tests; retains output-folder coverage. |
tests/integration/test_evaluation_runner.py |
Removes the unused single-conversation judging test and import. |
tests/conftest.py |
Removes legacy judge-log temporary-directory setup. |
src/vera_mh/judge/utils.py |
Deletes legacy helpers and requires an output folder for logs. |
src/vera_mh/judge/runner.py |
Deletes judge_single_conversation. |
src/vera_mh/judge/llm_judge.py |
Updates comments to reflect current logging behavior. |
src/vera_mh/judge/__init__.py |
Removes the deleted judging function’s export. |
src/vera_mh/generate/runner.py |
Deletes the unused conversation job builder. |
Review effort: Balanced
| judge_conversations, | ||
| judge_single_conversation, | ||
| ) | ||
| from .runner import judge_conversations |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Roadmap phase 1(a) (#294): delete code with no callers, left over from the legacy scripts.
The parameters every caller passes the same value for (`run_id`, `persona_names`, `verbose`) are not removed here: phase 1(b) and (c) rewrite those signatures, so they go there (roadmap update in #296).
Independent of the Role stack (#298, #299, #301): no shared files.
Checks
🤖 Generated with Claude Code