Skip to content
This repository was archived by the owner on Jun 28, 2026. It is now read-only.

Add fork-specific CVars + cleanup#150

Closed
metalgearsloth wants to merge 4 commits into
Space-Wizards-Federation:masterfrom
metalgearsloth:2026-05-25-cvars
Closed

Add fork-specific CVars + cleanup#150
metalgearsloth wants to merge 4 commits into
Space-Wizards-Federation:masterfrom
metalgearsloth:2026-05-25-cvars

Conversation

@metalgearsloth

@metalgearsloth metalgearsloth commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Branched from #147 so merge that first as it has all the spicy changes.

  • Should be backwards compat.
  • Saves fork-specific data into its own config so they don't bulldoze each other. Technically forks can re-use build IDs but I didn't see it as a huge deal?
  • Avoids saving server CVars on client and vice versa (client is absolutely spammed with these). I had an old PR but no idea where I put it.
  • Avoids the sussy raw File calls and uses the UserData variable like a good soldier.

Resolves #148
Resolves #149

Could do subcategories or something but this seemed easier to trackTM.

Standardises VFS a lot more with the actual file-system validation.
Add "IsValidFilePath" as a counterpart to "Clean" that avoids doing any traversal above the root.
Want these to do some CVar stuff on fork-specific CVar files.
- Should be backwards compat.
- Saves fork-specific data into its own config so they don't bulldoze each other. Technically forks can re-use build IDs but I didn't see it as a huge deal?
- Avoids saving server CVars on client and vice versa (client is absolutely spammed with these).
- Avoids the sussy raw File calls and uses the UserData variable like a good soldier.
/// <summary>
/// Non-default values are saved to a fork-specific configuration file.
/// </summary>
FORK = 1024,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a flag on CVarDefs attribute too so it doesnt have to be copy pasted 20 times

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eeyep

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CVar loading should not use raw file-system operations File operations should be logged

2 participants