Fix CVar saves + add fork-specific CVars#6667
Open
metalgearsloth wants to merge 6 commits into
Open
Conversation
Standardises VFS a lot more with the actual file-system validation. Add "IsValidFilePath" as a counterpart to "Clean" that avoids doing any traversal above the root. Want these to do some CVar stuff on fork-specific CVar files.
- Should be backwards compat. - Saves fork-specific data into its own config so they don't bulldoze each other. Technically forks can re-use build IDs but I didn't see it as a huge deal? - Avoids saving server CVars on client and vice versa (client is absolutely spammed with these). - Avoids the sussy raw File calls and uses the UserData variable like a good soldier.
# Conflicts: # RELEASE-NOTES.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see Space-Wizards-Federation/RobustToolbox#150