BUILD-11815: Remove SIGNING_PROFILE workaround from release pipeline#473
Merged
okorach-sonar merged 1 commit intoJul 7, 2026
Merged
Conversation
gh-action_azure-artifact-signing v1.1.0 auto-detects release signing on main and branch-* pushes, so the workflow no longer needs to override signing-profile manually.
Code Review ✅ ApprovedRemoves the redundant SIGNING_PROFILE workaround in favor of auto-detection provided by gh-action_azure-artifact-signing v1.1.0. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGNING_PROFILEenv var and explicitsigning-profileinput from the Windows Authenticode signing stepgh-action_azure-artifact-signingv1.1.0 auto-detection, which now treatsmainas a release branch alongsidemasterandbranch-*The workaround was added because the action previously only auto-selected the release profile on
master. With BUILD-11815 shipped in the action, manual profile selection is no longer needed.Test plan
sign-windowssucceeds on amainpush with release OIDC credentialsUsing signing profile 'release'without an explicitsigning-profileinput