fix(ci): remove stapler from macOS CLI signing (PREQ-7041)#476
Merged
Conversation
xcrun stapler only works on .app/.dmg/.pkg bundles, not bare Mach-O binaries. Codesign + notarization still succeed; stapler was failing with "Stapler is incapable of working with Document files" (exit 66). Aligns with sonarqube-cli which notarizes but does not staple raw binaries.
Code Review ✅ ApprovedRemoves the stapler step from the macOS CLI signing process, resolving the exit code 66 error caused by unsupported Mach-O binary stapling. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xcrun stapler staple/validatefrom thesign-macosjobRoot cause
xcrun stapleronly supports.app,.dmg, and.pkg— not bare Mach-O CLI binaries. After #468 added stapler and #469 switched to branch-based releases onmain, every release run failed with:Friday's
v1.0.0-rc2succeeded because it was built before stapler landed (tag release, no stapler step). Mate's #473 (WindowsSIGNING_PROFILEcleanup) did not break macOS — Windows signing works; macOS fails at stapler.This matches
sonarqube-cli, which notarizes zipped binaries but does not staple raw executables. Gatekeeper verifies notarization online on first launch.Test plan
sign-macospasses on amainpushpublishcompletes and release assets include signed darwin binariescodesign --verify+spctl -a -t exec -vvon downloaded darwin binary