Skip to content

Appman 2496 update course from ilr #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cofaulco wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Appman 2496 update course from ilr #767

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71afd51
tidy
cofaulco Mar 17, 2026
3888cd1
map course properties from learnerData sync
cofaulco Mar 17, 2026
ad657fa
fix typo
cofaulco Mar 18, 2026
d6d1bb1
Merge remote-tracking branch 'origin/master' into APPMAN-2496_update-…
cofaulco Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...itments/SFA.DAS.ProviderCommitments.Web/Mappers/EditDraftApprenticeshipViewModelMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using SFA.DAS.CommitmentsV2.Api.Types.Responses;
using SFA.DAS.CommitmentsV2.Api.Types.Responses;
using SFA.DAS.CommitmentsV2.Shared.Interfaces;
using SFA.DAS.CommitmentsV2.Types;
using SFA.DAS.Encoding;
Expand Down Expand Up @@ -139,7 +139,16 @@ public async Task ApplyLearnerDataSyncUpdates(EditDraftApprenticeshipViewModel e
editModel.Cost = updatedDraftApprenticeship.Cost;
editModel.HasLearnerDataChanges = false;
editModel.LastLearnerDataSync = DateTime.UtcNow;

editModel.DeliveryModel = (DeliveryModel?)updatedDraftApprenticeship.DeliveryModel;

if (!string.IsNullOrEmpty(updatedDraftApprenticeship.CourseCode))
{
editModel.CourseCode = updatedDraftApprenticeship.CourseCode;
editModel.CourseName = updatedDraftApprenticeship.TrainingCourseName;
editModel.TrainingCourseOption = updatedDraftApprenticeship.TrainingCourseOption == string.Empty ? "-1" : updatedDraftApprenticeship.TrainingCourseOption;

@Pauljgraham Pauljgraham Mar 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a course changes then the TrainingOption would be automatically cleared would it not? But we can see this in testing. The same goes for RPL, but we can leave this issue for testing. It's rare that a course will change after RPL is added.

MaxFundingBand may also need to be updated, but that field is not correctly populated in master and is awaiting a bug fix

editModel.TrainingCourseVersion = updatedDraftApprenticeship.TrainingCourseVersion;
}

await cacheStorageService.DeleteFromCache(learnerDataSyncKey);
}
}
Loading