Skip to content

Appman 2496 update course from ilr - #767

Open
cofaulco wants to merge 4 commits into
masterfrom
APPMAN-2496_update-course-from-ILR
Open

Appman 2496 update course from ilr#767
cofaulco wants to merge 4 commits into
masterfrom
APPMAN-2496_update-course-from-ILR

Conversation

@cofaulco

Copy link
Copy Markdown
Contributor

No description provided.

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/

@sonarqubecloud

Copy link
Copy Markdown

Pauljgraham
Pauljgraham previously approved these changes Mar 20, 2026
{
editModel.CourseCode = updatedDraftApprenticeship.CourseCode;
editModel.CourseName = updatedDraftApprenticeship.TrainingCourseName;
editModel.TrainingCourseOption = updatedDraftApprenticeship.TrainingCourseOption == string.Empty ? "-1" : updatedDraftApprenticeship.TrainingCourseOption;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a course changes then the TrainingOption would be automatically cleared would it not? But we can see this in testing. The same goes for RPL, but we can leave this issue for testing. It's rare that a course will change after RPL is added.

MaxFundingBand may also need to be updated, but that field is not correctly populated in master and is awaiting a bug fix

@das-github-app

das-github-app Bot commented Aug 5, 2026

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants