Skip to content

trait_solver: handle UnsafeBinder in Pointee/Discriminant normalizes_to #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebTardif wants to merge 1 commit into
base: main
Choose a base branch
from
Open

trait_solver: handle UnsafeBinder in Pointee/Discriminant normalizes_to #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions compiler/rustc_next_trait_solver/src/solve/normalizes_to.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,9 +793,14 @@ where
Some(tail_ty) => Ty::new_projection(cx, metadata_def_id, [tail_ty]),
},

ty::UnsafeBinder(_) => {
// FIXME(unsafe_binder): Figure out how to handle pointee for unsafe binders.
todo!()
// Pointee metadata follows the inner type (regions skipped at this
// solver stage), matching other ty queries on `UnsafeBinder`.
ty::UnsafeBinder(bound_ty) => {
let inner = bound_ty.skip_binder();
return Self::consider_builtin_pointee_candidate(
ecx,
goal.with(cx, goal.predicate.with_replaced_self_ty(cx, inner)),
);
}

ty::Infer(ty::TyVar(_) | ty::FreshTy(_) | ty::FreshIntTy(_) | ty::FreshFloatTy(_))
Expand Down Expand Up @@ -1001,12 +1006,9 @@ where
| ty::Slice(_)
| ty::Dynamic(_, _)
| ty::Tuple(_)
| ty::Error(_) => self_ty.discriminant_ty(ecx.cx()),

ty::UnsafeBinder(_) => {
// FIXME(unsafe_binders): instantiate this with placeholders?? i guess??
todo!("discr subgoal...")
}
| ty::Error(_)
// `discriminant_ty` already recurses through `UnsafeBinder` inners.
| ty::UnsafeBinder(_) => self_ty.discriminant_ty(ecx.cx()),

// Given an alias, parameter, or placeholder we add an impl candidate normalizing to a rigid
// alias. In case there's a where-bound further constraining this alias it is preferred over
Expand Down