trait_solver: handle UnsafeBinder in Pointee/Discriminant normalizes_to#587
Open
SebTardif wants to merge 1 commit into
Open
trait_solver: handle UnsafeBinder in Pointee/Discriminant normalizes_to#587SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Avoid todo! when normalizing Metadata or Discriminant on unsafe binder types: recurse through the inner type for Pointee, and use discriminant_ty (which already handles binders) for DiscriminantKind. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
todo!arms forUnsafeBinderwhen normalizing Pointee metadata (recurse through inner) and DiscriminantKind (usediscriminant_ty, which already handles binders).Closes #584
Related: #567, #565
Origin
rust-lang@9a1c5eb5b38
Test plan
Ty::discriminant_ty/ pointer_kind patterns on binders