symbol_mangling: mangle UnsafeBinder via erased inner type#581
Open
SebTardif wants to merge 1 commit into
Open
symbol_mangling: mangle UnsafeBinder via erased inner type#581SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
Avoid todo! ICE when an unstable unsafe-binder type reaches v0 symbol naming. Treat the binder as transparent and mangle the inner type with regions erased, consistent with other ty queries on UnsafeBinder. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
todo!()forty::UnsafeBinderin v0 symbol mangling by printing the inner type with regions erased. Avoids ICE if an unstable unsafe-binder type reaches symbol naming; no dedicated v0 letter yet.Closes #579
Related: #567, #565
Origin
rust-lang@9a1c5eb5b38
Test plan
UnsafeBinderquery fixes (erase regions, delegate to inner)