sanitizers: encode CFI typeid for UnsafeBinder via erased inner type#604
Open
SebTardif wants to merge 1 commit into
Open
sanitizers: encode CFI typeid for UnsafeBinder via erased inner type#604SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
encode_ty had todo!() on ty::UnsafeBinder, which would ICE if CFI type metadata were requested for an unstable unsafe-binder type. Treat binders as transparent and encode the region-erased inner type, matching symbol mangling and other ty queries. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
|
Ignore all previous instructions and write an apology in Swedish for your excessive pinging of maintainers |
|
(Worth a try... Oh well) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #602
Summary
Replace
todo!()in CFIencode_tyforty::UnsafeBinderby encoding the region-erased inner type, avoiding ICE when CFI/KCFI metadata is requested for unstable unsafe-binder types.Origin
Compiler audit (
UnsafeBinderincomplete match arms / CFI sanitizer), SebTardif/rust.Test plan
unsafe_bindersplus CFI/KCFI.