Skip to content

Rename fold solution variable for spellcheck#1031

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/rename-solf-spellcheck
Jul 10, 2026
Merged

Rename fold solution variable for spellcheck#1031
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/rename-solf-spellcheck

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Please ignore until reviewed by @ChrisRackauckas.

Summary

  • Rename the fold-continuation test result from solf to fold_solution.
  • Preserve the test behavior while satisfying typos-cli 1.48.0 without an allowlist or skipped check.

Root cause

On clean master c22bc9482254f58461cfa48361b739628f9087ab, typos-cli 1.48.0 reports solf at test/Core/homotopy_effort_tests__item2.jl:67-69.

A clean-worktree git bisect run identified 611cdf895a4ebc5e55e4d59fc552ee64889ea4b3 as the first bad commit. Its parent b704340349f0ed9014d108fca0b94c2d357e14a5 is good because the test file did not yet exist; the introducing commit creates the file with the flagged identifier.

This failure is unrelated to #1013, whose diff only touches the NonlinearSolveBase Enzyme extension.

Validation

  • timeout 3600 /home/crackauc/sandbox/tmp_20260708_165650_11549/tools/typos-v1.48.0/typos
    • Exit 0, no findings.
  • timeout 3600 /home/crackauc/.juliaup/bin/julia +1 --project=@runic -e 'using Runic; exit(Runic.main(["--check", "--diff", "."]))'
    • Exit 0, no formatting diff.
  • timeout 3600 env GROUP=Core /home/crackauc/.juliaup/bin/julia +1 --project=. -e 'using Pkg; Pkg.test(; coverage=false)'
    • Homotopy maxsteps guard + effort-band step control | 19/19
    • Ends with Testing NonlinearSolve tests passed.
  • git diff --check
    • Exit 0.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

Copy link
Copy Markdown
Member Author

Implementation scratchpad for commit db7d608907976594f1ad7f9e299f9d553b3922a8:

  • Clean master reproduction: typos-cli 1.48.0 exits 2 on solf at lines 67-69.
  • Independent clean-worktree bisect: first bad 611cdf895a4ebc5e55e4d59fc552ee64889ea4b3; parent b704340349f0ed9014d108fca0b94c2d357e14a5 is good.
  • Fix: semantic rename solf -> fold_solution in the test only.
  • Local validation: exact typos 1.48.0 exit 0; full Runic check exit 0; full GROUP=Core test passed, including the changed safetestset at 19/19.
  • GitHub's new Spell Check with Typos job is green. The remaining matrix is still running.

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 10, 2026 15:42
@ChrisRackauckas
ChrisRackauckas merged commit f9444fa into SciML:master Jul 10, 2026
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants