Rename fold solution variable for spellcheck#1031
Merged
ChrisRackauckas merged 1 commit intoJul 10, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Implementation scratchpad for commit
|
ChrisRackauckas
marked this pull request as ready for review
July 10, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Summary
solftofold_solution.Root cause
On clean master
c22bc9482254f58461cfa48361b739628f9087ab, typos-cli 1.48.0 reportssolfattest/Core/homotopy_effort_tests__item2.jl:67-69.A clean-worktree
git bisect runidentified611cdf895a4ebc5e55e4d59fc552ee64889ea4b3as the first bad commit. Its parentb704340349f0ed9014d108fca0b94c2d357e14a5is good because the test file did not yet exist; the introducing commit creates the file with the flagged identifier.This failure is unrelated to #1013, whose diff only touches the NonlinearSolveBase Enzyme extension.
Validation
timeout 3600 /home/crackauc/sandbox/tmp_20260708_165650_11549/tools/typos-v1.48.0/typostimeout 3600 /home/crackauc/.juliaup/bin/julia +1 --project=@runic -e 'using Runic; exit(Runic.main(["--check", "--diff", "."]))'timeout 3600 env GROUP=Core /home/crackauc/.juliaup/bin/julia +1 --project=. -e 'using Pkg; Pkg.test(; coverage=false)'Homotopy maxsteps guard + effort-band step control | 19/19Testing NonlinearSolve tests passed.git diff --check