Box Enzyme solve_up tape closure#1013
Conversation
|
Scratchpad update: the NonlinearSolve root matrix and NonlinearSolveBase sublibrary checks are green for this Enzyme tape fix. The remaining red checks are ModelingToolkit downstream jobs; local/log investigation traced these to SciML/.github#110 ( |
|
CI update: SciML/.github |
65f5c53 to
73f1a10
Compare
|
Rebased this branch on current Local verification on the rebased branch:
The stale |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
73f1a10 to
6ea947c
Compare
|
Rebased onto current master ( Local verification on the rebased head:
The prior ModelingToolkit InterfaceII failure is reproduced on unmodified NonlinearSolve master and is unrelated to this diff: registered |
|
The inherited |
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
solve_upEnzyme custom-rule tape inAny[...]so the SciMLSensitivity pullback closure does not become part of the concrete Enzyme tape type.Context
The latest master root CI failed intermittently in
tests / Adjoint (julia lts, macos-latest)with a Julia signal 11 intest/Adjoint/adjoint_tests__item3.jl. Recent runs show the same job/file/line can pass with identical Enzyme/SciMLSensitivity versions, so this targets robustness rather than changing the tested behavior.Validation
timeout 3600 env NONLINEARSOLVE_TEST_GROUP=Adjoint ~/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test(; julia_args=["--check-bounds=auto"])'\n-timeout 3600 ~/.juliaup/bin/julia +1 --project=. -e 'using Pkg; Pkg.test(; julia_args=["--check-bounds=auto"])'fromlib/NonlinearSolveBase\n-git diff --check\n-Runic.format_file(...; inplace=true)on the changed file from a temporary Julia environment with Runic v1.7.0\n