Define the piston test independent variable#485
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
|
Investigation scratchpad:
Next step: monitor this draft PR's CI and address any branch-related failure without expanding its scope. |
|
Additional validation on the published commit
The later |
|
CI classification for
The rotational relationship failure was independently reproduced on detached, unmodified MTSL main The downgrade-only thermal failure is also outside this piston-only diff. It still needs its own unmodified-main reproduction before being classified as a base-branch regression. |
|
CI reaches the separate pre-existing rotational regressions after the piston test passes. Those failures are fixed in follow-up #486, which is stacked on this branch; its fresh local run passes |
|
The long ModelingToolkit downstream job completed after ~2 hours. Its failure is unrelated to the piston test-only patch: MTK's curated The likely boundary is LinearSolve #1071 / v4.3.0, which introduced the extension; the underlying hazard is running multiple MTK group environments with different dependency versions in one |
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
@independent_variablesmacro from its owningModelingToolkitBasemodule.Context
ModelingToolkit source-history bisection identified
2785a86207f9d96fbe4f9395a4346228a43e8dd3(refactor: move DynamicQuantities to extension) as the commit that replaced the global independent variable withPleaseImportDynamicQuantities. ModelingToolkitStandardLibrary PR #483 defined an independent variable formotor.jl, butpiston.jlstill reproduced the same_check_if_dde(::Vector{Equation}, ::PleaseImportDynamicQuantities, ::Vector{System})MethodErroragainst current ModelingToolkit master.This uses the same public-owner import pattern as #483 and changes only the test fixture.
Local verification
include("test/piston.jl")reproduced thePleaseImportDynamicQuantitiesMethodError.2a9fc95e, the focused test passed:Piston cylinder wall | Pass 3 | Total 3 | 2m08.1s.GROUP=Core,Core/motor.jlpassed 6/6 andCore/piston.jlpassed 3/3. The run later stopped on unrelatedCore/rotational.jlfailures that also reproduce on an unmodified MTSL main checkout and are being investigated separately./home/crackauc/.juliaup/bin/julia +1.12 --startup-file=no -m Runic --check .exited 0.git diff --checkexited 0.