Initialize the FixedHeatFlow algebraic state#487
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
|
Investigation scratchpad Base: Reproduction used Julia 1.10.11 and the exact Clean-main diagnostic:
Providing only a guess of 299 K still produced For comparison, a separately resolved current graph with ModelingToolkit 11.31.2 generated History audit:
Validation commands and observed results: Result: all thermal testsets passed, 19/19 total; FixedHeatFlow passed 2/2. Result: all files before piston passed, including analog 100/100, continuous 76/76, digital 34/34, isothermal_compressible 27/27, math 93/93, multi_domain 17 passed plus 2 pre-existing broken, and nonlinear 15/15. The run then stopped at the clean-main piston Result: both exited successfully. All diagnostic environments and depots were removed before commit. |
|
CI downgrade classification for exact head The downgrade job resolved and ran Core successfully through No test was skipped or silenced here. Runic, Runic suggestions, discovery, and spell checks are green on this head. The remaining CI result is a known prerequisite failure, not a failure of the changed assertion. |
|
Terminal CI classification for
No failing test was skipped or silenced. The branch remains focused on the minimum-graph FixedHeatFlow regression. |
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
Why
The exact downgrade workflow graph selected by julia-actions/julia-downgrade-compat at
fab1defb76df9fd672f63c94df73ce131d32e134uses ModelingToolkit 11.2.0. On clean main, that graph leaves the only reduced state atInf, so initialization returnsInitialFailureeven though the observed heat flow is already 1 W. A 1 W flow across the 1 K/W wall places this port 1 K below the 300 K source, so the explicit 299 K initial value is model-consistent.Commit
c44704f3is the repository boundary that made the empty-GROUP downgrade invocation execute Core tests. The earlier apparent green run failed during precompilation and then executed zero tests. With current ModelingToolkit 11.31.2, the same model derives 299 K and succeeds without the explicit value; the added fixture keeps the minimum-compatible graph valid.Draft #485 independently addresses the clean-main piston failure encountered later in Core. This PR deliberately leaves the piston model unchanged.
Local validation
include("test/thermal.jl")— 19/19 passed, including FixedHeatFlow 2/2.GROUP=Core Pkg.test()on the exact downgraded graph: every preceding file passed through nonlinear 15/15; execution then reached the known clean-main piston error addressed by draft Define the piston test independent variable #485.git diff --check: passed.