Skip to content

add ci test coverage - #11

Merged
Radwa85 merged 32 commits into
developmentfrom
task/ci-test-coverage
Jul 4, 2025
Merged

add ci test coverage#11
Radwa85 merged 32 commits into
developmentfrom
task/ci-test-coverage

Conversation

@Radwa85

@Radwa85 Radwa85 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

1- Configured Kover to generate test coverage reports.

2- Created a GitHub Actions workflow that automatically runs tests and generates a coverage report on every pull request to the development branch.

3-Added logic to block PRs if overall coverage is below 80%

@Radwa85 Radwa85 linked an issue Jun 30, 2025 that may be closed by this pull request
@Radwa85 Radwa85 closed this Jun 30, 2025
@Radwa85 Radwa85 reopened this Jun 30, 2025
Comment thread app/build.gradle.kts Outdated
@mosayed01

Copy link
Copy Markdown
Contributor

The branch name violates the squad rules

@Radwa85 Radwa85 changed the title Task/ci test coverage add ci test coverage Jun 30, 2025
Comment thread .github/workflows/ci_test_coverage.yml Outdated
Comment thread .github/workflows/ci_test_coverage.yml Outdated
Comment thread .github/workflows/ci_test_coverage.yml Outdated
Comment thread app/build.gradle.kts Outdated
Comment thread app/build.gradle.kts Outdated
Comment thread .github/workflows/ci_test_coverage.yml Outdated
@mosayed01

Copy link
Copy Markdown
Contributor

Also u can use codecov github action to display the code coverage report result @Radwa85

Comment thread .github/workflows/ci_test_coverage.yml Outdated
Comment thread .github/workflows/ci_test_coverage.yml Outdated
@Ahmed7osny1

Copy link
Copy Markdown
Contributor

In general, you are good, but you need to change your commit to use Kover, not Jacoco
I don't know if you have tested this in a multi-module or not.

Comment thread .github/workflows/ci_test_coverage.yml Outdated
Comment thread build.gradle.kts
Comment thread build.gradle.kts
@Radwa85

Radwa85 commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@Radwa85 have u tested it?
@mosayed01 "Yes, I switched to the modularization branch and added some classes for test I confirmed that individual coverage reports are generated for each module which indicates tests are working per module

mosayed01
mosayed01 previously approved these changes Jul 2, 2025

@mostafa-n3ma mostafa-n3ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work
consider reading my coments please

Comment thread .github/workflows/ci_test_coverage.yml Outdated
Comment thread .github/workflows/ci_test_coverage.yml Outdated
@Radwa85 Radwa85 closed this Jul 3, 2025
@Radwa85
Radwa85 deleted the task/ci-test-coverage branch July 3, 2025 18:48
@codecov

codecov Bot commented Jul 3, 2025

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Radwa85 added 2 commits July 3, 2025 22:11
…overage

# Conflicts:
#	app/build.gradle.kts
#	build.gradle.kts
#	gradle/libs.versions.toml
mostafa-n3ma
mostafa-n3ma previously approved these changes Jul 3, 2025
Comment thread build.gradle.kts Outdated
shahad-97
shahad-97 previously approved these changes Jul 3, 2025
@Radwa85
Radwa85 dismissed stale reviews from shahad-97 and mostafa-n3ma via bf3175c July 3, 2025 22:50
@Radwa85
Radwa85 merged commit 87d162b into development Jul 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up a CI pipeline that checks for test coverage

6 participants