Skip to content

Correct decodeToken behavior#1877

Merged
evanugarte merged 15 commits into
devfrom
Adarsh/decodeToken
Oct 12, 2025
Merged

Correct decodeToken behavior#1877
evanugarte merged 15 commits into
devfrom
Adarsh/decodeToken

Conversation

@adarshm11

@adarshm11 adarshm11 commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

we don't really need any token functions besides decodeToken to check if

  • user is authenticated
  • user's authentication level meets the minimum requirement for role-specific functions (e.g. only officers can delete office access cards)

so we can delete all other token functions and absorb them into decodeToken

@weslayer weslayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adersh

@vietnguyen2358 vietnguyen2358 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thebeninator thebeninator left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@evanugarte evanugarte changed the title modify and streamline token functions Correct decodeToken behavior Oct 12, 2025
@evanugarte
evanugarte merged commit 92e0f3e into dev Oct 12, 2025
4 checks passed
@evanugarte
evanugarte deleted the Adarsh/decodeToken branch October 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants