OfficeAccessCard editing - backend changes by DavidN016 · Pull Request #1909 · SCE-Development/Clark

DavidN016 · 2025-09-20T05:40:29Z

-Created a post /edit, and a helper function for edit alias.
-Created edit mode in pencil/edit button, that edits the alias when clicked.
-Created test files for post /edit with dummy document.

- Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits.

adarshm11 · 2025-09-21T00:16:53Z

+        setCards(prevCards =>
+          prevCards.map(card =>
+            card._id === cardId
+              ? { ...card, alias: editedAlias.trim() }
+              : card


i think what we should do here is when the alias is successfully edited, we query mongodb for all cards again, so that way this alias isn't only client side

adarshm11 · 2025-09-21T00:18:41Z

+export function pencilSymbol(color = '#6b7280') {
+  return (
+    <svg width='20' height='20' viewBox='0 0 24 24' fill='none' stroke={color} strokeWidth='2' strokeLinecap='round' strokeLinejoin='round'>
+      <path d='M11 4H4a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2v-7'/>
+      <path d='m18.5 2.5a2.121 2.121 0 0 1 3 3L12 15l-4 1 1-4 9.5-9.5z'/>
+    </svg>
+  );
+}
+


this doesn't have to be put in this file, the trashCanSymbol function is only imported from here because it was already implemented here when card reader page was made. you can move this to CardReader.js

adarshm11 · 2025-09-21T00:19:26Z

+    it('Should return 400 when both _id and alias are missing', async () => {
+      setTokenStatus(true);
+      const result = await test.sendPostRequestWithToken(token,
+        EDIT_API_PATH, {});
+      expect(result).to.have.status(BAD_REQUEST);
+    });


this test is redundant

adarshm11 · 2025-09-21T00:20:12Z

+      expect(updatedCard.alias).to.equal(NEW_ALIAS);
+    });
+  });
+


very impressive how thorough these tests are :)

evanugarte

can there be some screenshots of the new ui

evanugarte · 2025-10-04T14:21:59Z

+  const decoded = decodeToken(req);
+  if (!decoded) {
+    return res.sendStatus(UNAUTHORIZED);
+  }


i think we realized this doesnt work anymore, need to merge #1877 first

ill work on it

adarshm11 · 2025-10-05T05:26:30Z

can there be some screenshots of the new ui

…ditalias

evanugarte · 2025-10-18T18:17:56Z

+  const { _id, alias } = req.body;
+
+  if (!_id || !alias) {
+    return res.status(BAD_REQUEST).send('_id and alias are required in request body');
+  }


we should do this approach, from the verify endpoint, alias.trim() can also be in the array

const required = [ { value: apiKey, title: 'X-API-Key HTTP header', }, { value: cardBytes, title: 'cardBytes query parameter', }, ]; const missingValue = required.find(({ value }) => !value); if (missingValue) { writeLogToClient(req.method, { statusCode: BAD_REQUEST, message: `${missingValue.title} missing from request` }); return res.status(BAD_REQUEST).send(`${missingValue.title} missing from request`); }

evanugarte · 2025-10-18T18:18:35Z

+  if (!/^[0-9a-fA-F]{24}$/.test(_id)) {
+    return res.status(BAD_REQUEST).send('_id must be a valid ObjectId');
+  }


you could even throw this in the missingFields thing

evanugarte · 2025-10-18T18:19:07Z

+    const updatedCard = await editAlias(_id, alias);
+
+    if (!updatedCard) {
+      return res.status(NOT_FOUND).send('Card not found');


we can just do sendStatus, 404 status implies that we didnt find it

evanugarte · 2025-10-18T18:20:21Z

+      action: AuditLogActions.EDIT_CARD,
+      details: {
+        newAlias: alias,
+        oldAlias: updatedCard.alias !== alias ? 'unknown' : alias


why would updatedCard.alias not exist

also we could just do

details: { newAlias: alias, _id, }

no need to say what the old one was

- Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits.

…into editalias

evanugarte · 2025-10-19T23:57:42Z

+  if (!apiKey) {
    writeLogToClient(req.method, {
      statusCode: UNAUTHORIZED,
-      message: `Invalid API key: ${apiKey}`,
+      message: 'API key missing from request',
    });
    return res.sendStatus(UNAUTHORIZED);
  }


do we even need this? the required array already checks this i think

evanugarte · 2025-10-19T23:58:18Z

+  const { _id, alias } = req.body;
+
+  const required = [
+    { value: _id && /^[0-9a-fA-F]{24}$/.test(_id) ? _id : null, title: 'Card ID', },


maybe have the title be valid, alphanumeric Card ID

evanugarte · 2025-10-19T23:58:46Z

          if (!result) {
-            const { description } = body;
-            logger.info(`Card:${description} not found in the database`);
+            logger.info('Card not found in the database');


why did we change this line can we put it back

evanugarte · 2025-10-19T23:59:52Z

+      expect(result).to.have.status(BAD_REQUEST);
+    });
+
+    it('Should preserve other card properties when updating alias', async () => {


up to you, should we add a quick test ensuring that only officers and above can edit a card, not member role

evanugarte · 2025-10-20T00:00:21Z

 });

+router.post('/edit', async (req, res) => {
+  const decoded = await decodeToken(req);


i think we have to pass in access role officer here, otherwise anyone with a valid token at any role level can do this

* Add edit alias functionality for OfficeAccessCard (#1900) - Implemented a new endpoint to edit card aliases, including validation for input. - Updated the OfficeAccessCard utility to support alias editing. - Enhanced the CardReader component to allow users to edit card aliases directly in the UI. - Added corresponding tests to ensure proper functionality and error handling for the new feature. - Introduced a new audit log action for alias edits. * fixed lint issues * fixed issues with edit alias * fixed input re-sizing * fix token decoding for office cards * fix failing test * card reader frontend * rebase * undo diff * fixed requested changes * fixed requested changes --------- Co-authored-by: DavidN016 <david.a.nguyen01@sjsu.edu>

DavidN016 added 2 commits September 19, 2025 22:28

fixed lint issues

29eff3e

adarshm11 reviewed Sep 21, 2025

View reviewed changes

DavidN016 and others added 2 commits September 20, 2025 23:36

fixed issues with edit alias

71bd95d

fixed input re-sizing

723f0a9

evanugarte reviewed Oct 4, 2025

View reviewed changes

adarshm11 added 2 commits October 12, 2025 17:06

Merge branch 'dev' of https://github.com/SCE-Development/Clark into e…

37c307b

…ditalias

fix token decoding for office cards

2513044

adarshm11 approved these changes Oct 15, 2025

View reviewed changes

adarshm11 force-pushed the editalias branch from 26def0a to 2513044 Compare October 18, 2025 06:28

adarshm11 changed the title ~~Add edit alias functionality for OfficeAccessCard (#1900)~~ OfficeAccessCard editing - UI changes Oct 18, 2025

fix failing test

a3cec14

adarshm11 force-pushed the editalias branch 2 times, most recently from 003c142 to a3cec14 Compare October 18, 2025 17:51

adarshm11 changed the title ~~OfficeAccessCard editing - UI changes~~ OfficeAccessCard editing - backend changes Oct 18, 2025

adarshm11 force-pushed the editalias branch from f889ffe to 7e8e47c Compare October 18, 2025 17:55

separate frontend changes

a7fa4e8

adarshm11 force-pushed the editalias branch from 7e8e47c to a7fa4e8 Compare October 18, 2025 18:00

evanugarte reviewed Oct 18, 2025

View reviewed changes

DavidN016 and others added 9 commits October 18, 2025 11:31

fixed lint issues

654e390

fixed issues with edit alias

e2b2fc3

fixed input re-sizing

540d7a2

fix token decoding for office cards

81fa920

fix failing test

f5c01be

separate frontend changes

02803f1

Merge branch 'editalias' of https://github.com/SCE-Development/Clark …

7c39290

…into editalias

modify required checks for /edit

580cf9c

adarshm11 force-pushed the editalias branch from a3446bb to 580cf9c Compare October 18, 2025 18:54

evanugarte reviewed Oct 20, 2025

View reviewed changes

adarshm11 added 2 commits October 19, 2025 20:31

addressed requested changes

51223d1

try to fix failing test

c6d2980

adarshm11 force-pushed the editalias branch 2 times, most recently from 3cee241 to a902e38 Compare October 20, 2025 04:30

try to fix that failing test one more time

a44449f

adarshm11 force-pushed the editalias branch from a902e38 to a44449f Compare October 20, 2025 04:34

remove this test cuz it wont work

21a0352

evanugarte approved these changes Oct 21, 2025

View reviewed changes

adarshm11 merged commit 7357224 into dev Oct 21, 2025
7 of 8 checks passed

adarshm11 deleted the editalias branch October 21, 2025 04:49

Uh oh!

Conversation

DavidN016 commented Sep 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evanugarte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adarshm11 commented Oct 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants