Refactor handling of mouse messages - #1850
Merged
Merged
Conversation
Merged
Flow86
approved these changes
Dec 30, 2025
Flamefire
enabled auto-merge (rebase)
December 31, 2025 11:50
- Unify selection if active window. - Always use `Relay*` where possible - Stop handling if any control handled it
When moving the mouse to the button while holding the left mouse button the click should not be registered, nor should the button show as pressed.
Also make layout more adaptive
Flamefire
force-pushed
the
mouse-click
branch
from
December 31, 2025 11:51
133ba88 to
c015ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relay*where possibleAlso fix wrongly detected clicks on title bar of ingame windows:
When moving the mouse to the button while holding the left mouse button
the click should not be registered, nor should the button show as pressed.
This is what I announced at #1804 (comment) for #1804 to not call the ingame window method when a control handled it and get rid of the additional methods for handling mouse events in the window