Android build

[Farmer-Markus]

I'm working on recreating my android port of rttr.
Currently the game starts but failes to find any drivers.

I would need an option to set a custom output path for the translation/data copying.
Also an enviroment variable to set the path to the drivers or the game data (or both)

Also another problem is openGl.
On android only openGl-Es is available and I've used a translation library (gl4es) that works pretty well. But the SDL videodriver would need: 1. to link against gl4es and 2. the SDL_gl_getprocaddress to be replaced by the gl4es equivalent.
This could also be used to support devices like the raspberry pi.

Also I would implement basic touch controls which should also work on touchscreen laptops (thanks to sdl)

I know these would be some pretty big changes...

[Farmer-Markus]

Changes:

• Added 'natural' mouse mode & changed invert mouse setting to mouseMode (0:default, 1:inverted, 2:natural)
• Changed invert mouse GUI setting (translations would need to be added/changed)
• Added 'GL4ES' to RTTR_OPENGL cmake options & VideoSDL2 driver to support OpenGL-ES
• Added 'RTTR_BUILD_LIB' cmake variable to build main executable as shared library (Needed to run on android)
• Added Touch controls to VideoSDL2 driver (moving map with one finger, two finger zooming, double tap to close window)
• Added allowing to control config paths using enviroment variables
• Some minor changes to fix compiling with newer versions of gcc and clang

[Flow86]

Git History should be cleaned up (Some things should be squashed, so that some distinguish commits are there)

[Flamefire]

#1850 will be merged after its CI finishes.

I think the last open issue here was the handling of a double-touch as double-click to close the window. So you can incorporate that (merge or rebase) and check the suggestion I just made. If it works in your tests with those then I'd say this is ready :-)

[Flow86]

If it works in your tests with those then I'd say this is ready :-)

maybe a proper rebase & squashing some of the commits to proper commits would be nice ;-)

[Farmer-Markus]

maybe a proper rebase & squashing some of the commits to proper commits would be nice ;-)

Is this ok?

[Flamefire]

@Farmer-Markus I made a rebase of your branch on current master formatting each commit. 2 other changes:

• Move methods in dskGameInterface to make the diff smaller
• Return true when double-tap closes ingame window

Also each commit now builds so I could remove the comments from the last 2 commit titles.

Can you verify that this works for you too? You have to pull and reset your local branch due to the force-push.
I did check the diffs at each step but just want to make sure nothing slipped through, I'd really like to get this in :)

[Farmer-Markus]

* Return `true` when double-tap closes ingame window

Everything works fine but now windows are closed by dbl clicking on the top bar instead of being minimized.
But I don't know if this was intentional

[Flamefire]

Everything works fine but now windows are closed by dbl clicking on the top bar instead of being minimized.
But I don't know if this was intentional

It was not and I think this wasn't caused by my changes

Currently minimizing happens only when window-pinning is enabled and double-clicking the title bar: if(SETTINGS.interface.enableWindowPinning && mc.dbl_click)

Your commit 629bc2c removed the check if any button was pressed.

Where was/should be the code that minimizes the window on double-tapping the title bar?

Maybe we should:

• always return true when any button is hit (if(IsPointInRect(mc.pos, GetButtonBounds(btn))))
• in the Title case check if((SETTINGS.interface.enableWindowPinning || VIDEODRIVER.IsTouch()) && mc.dbl_click) to enable it for touch

Or (possibly better) use subconditions in the bottom if(VIDEODRIVER.IsTouch() && mc.dbl_click to check if inside titlebar and handle either as close or minimize there.
It might make sense to pull the conditions for modal windows to where they matter instead of continuing or the double-tap check might need to check for the 2 buttons too as they might be clicked but inactive and then we don't want to close, do we?

[Farmer-Markus]

Your commit 629bc2c removed the check if any button was pressed.

Ok now I see why.

Where was/should be the code that minimizes the window on double-tapping the title bar?

I think I'm just messing up my memories. It should close when dblclick on titlebar and window pinning isn't enabled.

Maybe we should:

* always `return true` when any button is hit (`if(IsPointInRect(mc.pos, GetButtonBounds(btn)))`)

* in the `Title` case check `if((SETTINGS.interface.enableWindowPinning || VIDEODRIVER.IsTouch()) && mc.dbl_click)` to enable it for touch

Or (possibly better) use subconditions in the bottom if(VIDEODRIVER.IsTouch() && mc.dbl_click to check if inside titlebar and handle either as close or minimize there. It might make sense to pull the conditions for modal windows to where they matter instead of continuing or the double-tap check might need to check for the 2 buttons too as they might be clicked but inactive and then we don't want to close, do we?

I don't think we need to do additional changes. It works how it's intended :D

* always `return true` when any button is hit (`if(IsPointInRect(mc.pos, GetButtonBounds(btn)))`)

We could change this just to keep the window open and not accidentally close the window when trying to drag but I think this shouldn't be a serious problem.

[Flamefire]

I think I'm just messing up my memories. It should close when dblclick on titlebar and window pinning isn't enabled.

We could change this just to keep the window open and not accidentally close the window when trying to drag but I think this shouldn't be a serious problem.

Just to be sure: Double-tap anywhere should close the window except for non-modal windows in these cases:

• When window pinning is enabled double-tap on title will minimize
• double-tap on minimize/pin will minimize/pin (effectively nothing as done twice and hence reverts to previous)

Correct?

[Farmer-Markus]

I think I'm just messing up my memories. It should close when dblclick on titlebar and window pinning isn't enabled.

We could change this just to keep the window open and not accidentally close the window when trying to drag but I think this shouldn't be a serious problem.

Just to be sure: Double-tap anywhere should close the window except for non-modal windows in these cases:

• When window pinning is enabled double-tap on title will minimize
• double-tap on minimize/pin will minimize/pin (effectively nothing as done twice and hence reverts to previous)

Correct?

Yes Correct

[Farmer-Markus]

@Flamefire I've fixed another very annoying bug with disable_mouse when using touch controls.
I hope this didn't broke your rebase or other stuff :/

You would always need to click twice to open a IgWindow if misclicked and opened the wrong one.
Just added the following to WindowManager::DoShow(

+ if(!VIDEODRIVER.IsTouch())
       disable_mouse = true;

Sorry for the many force-pushes my editor is playing games with me and not showing files how the actually are...

[Flamefire]

Sorry for the many force-pushes my editor is playing games with me and not showing files how the actually are...

But why force-push at all? That new change is unrelated to the previous commit so shouldn't be in it.

I extracted it to a separate commit and queueing this for merge :)

[Farmer-Markus]

I extracted it to a separate commit and queueing this for merge :)

Thank you! I've learned so much during this PR :D