Fix hand-eye pose matching - #15
Open
Daniel-rmc wants to merge 3 commits into
Open
Conversation
Open
added 2 commits
April 16, 2026 20:30
fhyaaa
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14
This fixes a pose/image pairing bug in
compute_in_hand.pyandcompute_to_hand.py.Previously, when some checkerboard images failed detection, the scripts appended only successful image observations but still paired them with the first N robot poses from
poses.txt. This caused later images to be matched with the wrong robot end-effector poses.The fix tracks the numeric image id for every successful checkerboard detection and uses that id to select the corresponding line from
poses.txt.Root Cause
For example, if
11.jpgand12.jpgfail checkerboard detection, the old code pairs:13.jpgwith pose line 1114.jpgwith pose line 1215.jpgwith pose line 13This produces a wrong hand-eye transform even when the collected data is otherwise valid.
Changes
N.jpgwith lineNinposes.txt.Validation
python3 -m py_compile compute_in_hand.py compute_to_hand.py11.jpgand12.jpgfailed detection.