Skip to content

#84 Independent visibility toggles for Color Grading and Color Mixer #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yojen7 merged 9 commits into from
Oct 4, 2026
Merged

#84 Independent visibility toggles for Color Grading and Color Mixer #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8830dc0
feat(adjustments): add visibility toggles for color grading and mixer
lalibertemarc Oct 1, 2026
2c46f15
Treat a missing section visibility key as visible when toggling
claude Oct 4, 2026
ba8c6f2
Change list and credits: Color Grading / Color Mixer visibility toggles
claude Oct 4, 2026
a7825a5
Test colour tool visibility: absent keys, independent tools, parent eye
claude Oct 4, 2026
504e8b2
Preview catalog photo edits before selective import (#77)
yojen7 Oct 4, 2026
0b5c037
Merge current main into color-tool visibility verification
yojen7 Oct 4, 2026
57b1453
Expose visibility controls to keyboard and screen-reader users
yojen7 Oct 4, 2026
334f8ec
Merge verified catalog develop import before color-tool visibility va…
yojen7 Oct 4, 2026
4871aa1
Regenerate status docs after catalog and color-tool integration
yojen7 Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ RapidRAW is a free, open-source raw editor by [Timon Käch (CyberTimon)](https:/
- **Pick and reject flags for culling,** separate from stars: P, X and U as in Lightroom, a flag filter, and rejects that darktable, Bridge and Lightroom understand.
- **Presets at your fingertips.** Presets sit in the left sidebar as compact rows: hover to preview one on your photo, click to apply, and star favorites to pin them on top.

52 improvements on top of RapidRAW so far, including fixes for 18 upstream issues that are still open there. Every change, with its source and upstream status, is in the [changelog](../CHANGES.md).
54 improvements on top of RapidRAW so far, including fixes for 18 upstream issues that are still open there. Every change, with its source and upstream status, is in the [changelog](../CHANGES.md).
<!-- rapidroom-changes:end -->

## Why RapidRoom
Expand Down
22 changes: 21 additions & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ Everything RapidRoom adds on top of upstream [RapidRAW](https://github.com/Cyber

<sub>Generated from [rapidroom/changes.json](rapidroom/changes.json) by `node rapidroom/status.mjs`; don't edit by hand.</sub>

**52 changes on top of RapidRAW.** 19 fix upstream issues that had been open a median of 63 days when RapidRoom shipped the fix; 18 of them still open upstream. 14 offered upstream as PRs, 3 merged so far.
**54 changes on top of RapidRAW.** 19 fix upstream issues that had been open a median of 63 days when RapidRoom shipped the fix; 18 of them still open upstream. 14 offered upstream as PRs, 3 merged so far.

| Change | Type | By | Upstream |
| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------- | ------------------------------------------------------------------------------------------------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| Preview and selectively import Lightroom catalog photo edits, crop, straighten, rotation, star ratings and virtual copies, with unsupported-setting reports and independent replacement choices | feature | [@laurensiusadi](https://github.com/laurensiusadi), [@yojen7](https://github.com/yojen7) | not yet offered |
| Import Lightroom Classic collections and collection sets from a .lrcat catalog as albums, with a preview of found and missing photos and relinking of moved root folders | feature | [@Bennyyy27](https://github.com/Bennyyy27) | not yet offered |
| Faster raw decoding: highlight recovery and pixel-format conversions run on all CPU cores; the GPU adapter is logged; `rapidraw bench` measures the image pipeline without a window | performance | [@elhigu](https://github.com/elhigu) | PR [#1790](https://github.com/CyberTimon/RapidRAW/pull/1790) open |
| Batch rename treats a photo as one unit: RAW+JPEG/HEIF pairs and every sidecar (.rrdata incl. virtual copies, both XMP styles, .acr, .dop, .pp3) move together, with metadata, burst and group tokens, a preview with collision checks, a rollback-safe two-phase rename and undo | feature | [@yojen7](https://github.com/yojen7), [@SandeepSubba](https://github.com/SandeepSubba) | PR [#1309](https://github.com/CyberTimon/RapidRAW/issues/1309) |
Expand Down Expand Up @@ -63,11 +64,21 @@ Everything RapidRoom adds on top of upstream [RapidRAW](https://github.com/Cyber
| Import old Lightroom `.lrtemplate` presets stored as plain Lua tables, without running any Lua | feature | [@laurensiusadi](https://github.com/laurensiusadi) | not yet offered |
| Pick and reject flags, separate from star ratings: P / X / U shortcuts, badges, a flag filter (picked, unflagged, hide rejected, rejected) and Delete rejected | feature | [@lalibertemarc](https://github.com/lalibertemarc), [@yojen7](https://github.com/yojen7) | [#1599](https://github.com/CyberTimon/RapidRAW/issues/1599); [#994](https://github.com/CyberTimon/RapidRAW/issues/994); [#1057](https://github.com/CyberTimon/RapidRAW/issues/1057) |
| Presets move to the left sidebar with compact rows, hover previews, favorites and folder reordering | feature | [@laurensiusadi](https://github.com/laurensiusadi) | not yet offered |
| Color Grading and Color Mixer get their own visibility eye, globally and in masks; the Color panel eye still bypasses every colour tool | feature | [@lalibertemarc](https://github.com/lalibertemarc) | PR [#1833](https://github.com/CyberTimon/RapidRAW/issues/1833) |

⚑ changes rendered output on purpose. Upstream status as of 2026-10-04.

## Details

### Preview and selectively import Lightroom catalog photo edits, crop, straighten, rotation, star ratings and virtual copies, with unsupported-setting reports and independent replacement choices

- **Type:** feature
- **Landed in RapidRoom:** 2026-10-04
- **By:** [@laurensiusadi](https://github.com/laurensiusadi), [@yojen7](https://github.com/yojen7), from laurensiusadi/RapidRAW, adapted in RapidRoom with the shared read-only catalog reader and current image-aware XMP mapper
- **Upstream:** not yet offered
- **Commits:** [dda6cc5](https://github.com/laurensiusadi/RapidRAW/commit/dda6cc51c69dc6a17906609dbb667eff3507aeeb)
- **Notes:** Catalogs and originals are read only. Reuses the collections root resolver and bounded Lua-table parser; caps compressed rows at 4 MiB. Preview lists converted controls, unsupported settings, missing originals and unreadable sidecars before an explicit selection is applied. Existing edits, cleared ratings, keywords, EXIF and other metadata are preserved unless the relevant replacement choice is enabled. Uses atomic sidecars, Card mode guards, stale-preview checks and stable full-ID virtual-copy identities. As-shot white balance requires an explicit history reference; no folder median is estimated. Supported nested profile tone curves use the existing mapper; Adobe profiles, local/AI masks and other unsupported fields are reported. Synthetic native/frontend coverage and private sidecar-derived synthetic-catalog calibration only; real Lightroom catalogs, desktop interaction and other platforms still need human checks. Adobe rendering parity is not promised. Adapted with Codex, with source authorship retained.

### Import Lightroom Classic collections and collection sets from a .lrcat catalog as albums, with a preview of found and missing photos and relinking of moved root folders

- **Type:** feature
Expand Down Expand Up @@ -520,3 +531,12 @@ Everything RapidRoom adds on top of upstream [RapidRAW](https://github.com/Cyber
- **Upstream:** not yet offered
- **Commits:** [9535884](https://github.com/laurensiusadi/RapidRAW/commit/953588443099def3fd0c5e92a55e1966d994e385), [9e478b6](https://github.com/laurensiusadi/RapidRAW/commit/9e478b66eeee63be3e79238af708916655f52125)
- **Notes:** Hovering a preset previews it on the image without touching the edit, its history or sidecars; only a click applies it. Saved workspaces keep their layout: Presets only moves when it is still in its old default spot on the right. Preset preview thumbnails are gone. Enter/Space apply a focused preset. Scrollbar thumbs across the app are more subtle.

### Color Grading and Color Mixer get their own visibility eye, globally and in masks; the Color panel eye still bypasses every colour tool

- **Type:** feature
- **Landed in RapidRoom:** 2026-10-04
- **By:** [@lalibertemarc](https://github.com/lalibertemarc), from lalibertemarc/RapidRAW
- **Upstream:** PR [#1833](https://github.com/CyberTimon/RapidRAW/issues/1833)
- **Commits:** [879b414](https://github.com/lalibertemarc/RapidRAW/commit/879b4146fa4d87ecfa3580261cfc0554ffb1555f)
- **Notes:** New sectionVisibility.colorGrading/colorMixer keys default to on, so existing sidecars and presets render unchanged; turning a tool off intentionally skips it. Resetting or pasting the Color section re-enables both tools.
3 changes: 3 additions & 0 deletions CREDITS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ RapidRoom is built on other people's work. This file lists where every non-upstr
| Lua-table `.lrtemplate` preset import | [@laurensiusadi](https://github.com/laurensiusadi) (Laurensius Adi), adapted with Claude Code | [laurensiusadi/RapidRAW@bb60210](https://github.com/laurensiusadi/RapidRAW/commit/bb60210c609c6939d34deba9c1043fe9d01bde92) |
| Pick and reject flags | [@lalibertemarc](https://github.com/lalibertemarc), adapted by @yojen7 with Claude Code | [lalibertemarc/RapidRAW@1b4b9db](https://github.com/lalibertemarc/RapidRAW/commit/1b4b9db115f0c1aa6f12e2b4bc0515ffb7fb0eb6) |
| Presets sidebar with hover previews, favorites, folder reordering | [@laurensiusadi](https://github.com/laurensiusadi) (Laurensius Adi), adapted by Claude Code | [9535884](https://github.com/laurensiusadi/RapidRAW/commit/953588443099def3fd0c5e92a55e1966d994e385), [9e478b6](https://github.com/laurensiusadi/RapidRAW/commit/9e478b66eeee63be3e79238af708916655f52125) in laurensiusadi/RapidRAW |
| Separate visibility toggles for Color Grading and Color Mixer | [@lalibertemarc](https://github.com/lalibertemarc) with Claude | [lalibertemarc/RapidRAW@879b414](https://github.com/lalibertemarc/RapidRAW/commit/879b4146fa4d87ecfa3580261cfc0554ffb1555f) (upstream PR `CyberTimon/RapidRAW#1833`) |

| Lightroom catalog photo-edit previews and selective develop/virtual-copy import | [@laurensiusadi](https://github.com/laurensiusadi) (Laurensius Adi), adapted by yojen7 with Codex | [laurensiusadi/RapidRAW@dda6cc5](https://github.com/laurensiusadi/RapidRAW/commit/dda6cc51c69dc6a17906609dbb667eff3507aeeb); shares the existing catalog reader and XMP mapper |

## RapidRoom changes

Expand Down
26 changes: 26 additions & 0 deletions rapidroom/changes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
{
"$comment": "Everything RapidRoom adds on top of upstream RapidRAW. Edit this file in the same PR as the change; `node rapidroom/status.mjs` renders the README table and CHANGES.md. Fields: id, title, category (fix | feature | performance | privacy | platform | ci), landed (YYYY-MM-DD, date it reached RapidRoom main), authors (GitHub logins), source (rapidroom, or the fork it was harvested from), commits (URLs), upstream_issues and upstream_prs ('owner/repo#n'), rendering_change, notes, highlight (optional: a short, user-facing Markdown line; entries with one are listed under Highlights in the README, everything is in CHANGES.md).",
"changes": [
{
"id": "lightroom-catalog-develop-import",
"title": "Preview and selectively import Lightroom catalog photo edits, crop, straighten, rotation, star ratings and virtual copies, with unsupported-setting reports and independent replacement choices",
"category": "feature",
"landed": "2026-10-04",
"authors": ["laurensiusadi", "yojen7"],
"source": "laurensiusadi/RapidRAW, adapted in RapidRoom with the shared read-only catalog reader and current image-aware XMP mapper",
"commits": ["https://github.com/laurensiusadi/RapidRAW/commit/dda6cc51c69dc6a17906609dbb667eff3507aeeb"],
"upstream_issues": [],
"upstream_prs": [],
"rendering_change": false,
"notes": "Catalogs and originals are read only. Reuses the collections root resolver and bounded Lua-table parser; caps compressed rows at 4 MiB. Preview lists converted controls, unsupported settings, missing originals and unreadable sidecars before an explicit selection is applied. Existing edits, cleared ratings, keywords, EXIF and other metadata are preserved unless the relevant replacement choice is enabled. Uses atomic sidecars, Card mode guards, stale-preview checks and stable full-ID virtual-copy identities. As-shot white balance requires an explicit history reference; no folder median is estimated. Supported nested profile tone curves use the existing mapper; Adobe profiles, local/AI masks and other unsupported fields are reported. Synthetic native/frontend coverage and private sidecar-derived synthetic-catalog calibration only; real Lightroom catalogs, desktop interaction and other platforms still need human checks. Adobe rendering parity is not promised. Adapted with Codex, with source authorship retained."
},
{
"id": "lightroom-collections-import",
"title": "Import Lightroom Classic collections and collection sets from a .lrcat catalog as albums, with a preview of found and missing photos and relinking of moved root folders",
Expand Down Expand Up @@ -726,6 +739,19 @@
"rendering_change": false,
"notes": "Hovering a preset previews it on the image without touching the edit, its history or sidecars; only a click applies it. Saved workspaces keep their layout: Presets only moves when it is still in its old default spot on the right. Preset preview thumbnails are gone. Enter/Space apply a focused preset. Scrollbar thumbs across the app are more subtle.",
"highlight": "**Presets at your fingertips.** Presets sit in the left sidebar as compact rows: hover to preview one on your photo, click to apply, and star favorites to pin them on top."
},
{
"id": "color-tool-visibility",
"title": "Color Grading and Color Mixer get their own visibility eye, globally and in masks; the Color panel eye still bypasses every colour tool",
"category": "feature",
"landed": "2026-10-04",
"authors": ["lalibertemarc"],
"source": "lalibertemarc/RapidRAW",
"commits": ["https://github.com/lalibertemarc/RapidRAW/commit/879b4146fa4d87ecfa3580261cfc0554ffb1555f"],
"upstream_issues": [],
"upstream_prs": ["CyberTimon/RapidRAW#1833"],
"rendering_change": false,
"notes": "New sectionVisibility.colorGrading/colorMixer keys default to on, so existing sidecars and presets render unchanged; turning a tool off intentionally skips it. Resetting or pasting the Color section re-enables both tools."
}
]
}
Loading
Loading