Repository navigation
#84 Independent visibility toggles for Color Grading and Color Mixer - #106
Merged
Merged
Conversation
The Color panel eye bypasses every color tool at once. Color Grading and Color Mixer now get their own eye toggle, stored per image and per mask as sectionVisibility.colorGrading / colorMixer (default on, so existing sidecars render unchanged). The renderer applies each only when both the Color panel and the tool are visible. Resetting or pasting a section re-enables its tool toggles. The eye button is extracted into a shared VisibilityToggle used by both CollapsibleSection and AdjustmentSubSection, and the Rust section visibility lookup is shared between the global and mask builders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 879b4146fa4d87ecfa3580261cfc0554ffb1555f)
A sectionVisibility object without the new colorGrading/colorMixer keys (an older or partial one) made the first eye click a no-op, because !undefined is true. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHAmUdMPzKcgwDMEftFCrN
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHAmUdMPzKcgwDMEftFCrN
Absent or partial sectionVisibility must produce byte-identical uniforms to an explicit all-on one, for global and mask adjustments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHAmUdMPzKcgwDMEftFCrN
yojen7
added
harvest
Claude
Adapt Laurensius Adi's develop-row source using the existing read-only catalog/path resolver, bounded Lua parser and image-aware XMP mapper. Add explicit per-photo selection, independent edit/rating replacement, stale-preview checks, atomic writes and stable virtual-copy IDs. Preserve unrelated metadata and reject unreadable edits and Card paths. (from laurensiusadi/RapidRAW@dda6cc5) Omit the original second catalog reader, line-based adjustment mapping, folder-median white-balance estimates, default-sharpening heuristic, truncated virtual IDs and unreviewed writes. Reuse the current mapper for supported nested profile luma curves; report unsupported profile/mask data. Written and reviewed with Codex. Native/frontend fixtures cover read-only preview, preservation/replacement, repeat/stale/partial failure and Card mode. Real catalog and desktop/platform checks remain unavailable. Co-authored-by: Laurensius Adi <laurensiusadi@gmail.com>
Retain all change/credit entries and both color-visibility and pixel-format conversion test modules.
Give the shared eye button a translated accessible label and pressed state; reveal focused eyes in subsection and section headers. Co-authored-by: marclaliberte <laliberte.marc1@gmail.com>
…lidation Retain the read-only importer, all credits and change entries; validate the full stacked source before pushing or merging.
This was referenced Oct 4, 2026
Contributor
Author
|
Verified and merged as
Desktop global/mask eyes, keyboard focus, reset/paste/undo/autosave and older edits still need human checks in #63. No desktop interaction claimed. Numerical evidence/logs retained in |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84
What and why
Color Grading and Color Mixer now have independent eye switches globally and per mask. The parent Color eye still bypasses both. Missing keys preserve old sidecars; Reset and Paste re-enable the section and its tools. The shared eye button now has a translated accessible name, pressed state and keyboard focus visibility.
Integrated with current main and the verified catalog develop work in #128. This branch contains that preceding work; merge #128 first.
Source
lalibertemarc/RapidRAW, 879b4146, by marclaliberte (upstream PRCyberTimon/RapidRAW#1833). Original author and Claude coauthor trail retained; CREDITS.md retained. Author contact remains a maintainer decision.rapidroom/changes.json; generated docs checked.How it was made
Who answers review: Yojen with Codex; maintainers decide.
Testing
baseline-int7, same Intel xe / Mesa 26.2.2 / Linux 7.2.5 environment. No reference or tolerance changes. Pinned engine SHA-256ea5b4233f08f7e892c44e0986cdf7b413bb545ceadfface732ee792fd66aeeb0.Desktop, mask UI, autosave/undo and other platforms still need human checks in #63. Hosted CI must pass for this exact head before merge.
Screenshots / before and after
Local CC0 evidence:
samples/color-tool-validation-codex-106/color-tool-before-after.png(visually inspected), six focused TIFFs and numerical results in/tmp/rapidroom-codex-106/focused-results.json. These demonstrate bypass behavior, with no image-quality claim. Full-corpus comparison JSON and manifest are retained locally; temporary corpus TIFFs removed.