test : [amdsmi] Add test filter standardization#8995
Draft
dileepr1 wants to merge 1 commit into
Draft
Conversation
Add quick/standard/comprehensive/full CTest categorization for the amdsmitst gtest suite so TheRock's generic test_runner.py can drive `ctest -L <category>` from the installed tree. - projects/amdsmi/tests/amd_smi_test/test_categories.yaml: categories + shared exclude anchor + per-arch exclude_gpu blocks, mirroring the legacy TheRock test_amdsmi.py filters and amdsmitst.exclude. - projects/amdsmi/CMakeLists.txt: set ROCM_SYSTEMS_ROOT for shared/ctest. - tests/amd_smi_test/CMakeLists.txt: include shared/ctest, call apply_test_category_labels(amdsmitst ...) and install the generated CTestTestfile.cmake to share/amd_smi/tests/ctest so the relative "../amdsmitst" path resolves. Guarded on shared/ctest so standalone checkouts keep building. - Point TheRock CI workflows at users/dravindr/tr_amdsmi. WIP: revert the TheRock workflow refs to a pinned ROCm/TheRock SHA before merge, once the paired tr_amdsmi PR lands. Co-authored-by: Cursor <cursoragent@cursor.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
dileepr1
marked this pull request as draft
July 21, 2026 22:52
dileepr1
added a commit
to ROCm/TheRock
that referenced
this pull request
Jul 22, 2026
Bump the rocm-systems submodule to the tip of the paired branch users/dravindr/tf_amdsmi (ROCm/rocm-systems@53a45d9e), which adds the amdsmi test_categories.yaml and installs share/amd_smi/tests/ctest/CTestTestfile.cmake via apply_test_category_labels(). This lets TheRock CI build amdsmi with the install-time CTest categories so test_runner.py can run `ctest -L <category>`. WIP: revert the submodule pin to a rocm-systems develop SHA once the tf_amdsmi PR (ROCm/rocm-systems#8995) merges. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Paired TheRock PR (draft): ROCm/TheRock#6784 — switches the amdsmi test job to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test-filter / test-category standardization for amdsmi, so TheRock's generic
test_runner.pycan drivectest -L {quick|standard|comprehensive|full}for theamdsmitstgtest suite from the installed tree.Paired with TheRock branch
users/dravindr/tr_amdsmi(switches the amdsmitest_scripttotest_runner.pyand adds aCOMPONENT_OVERRIDESentry pointing ctest atshare/amd_smi/tests/ctest).Follows the same shared
shared/ctestinfrastructure as other rocm-systems components; closest analog is rocrtst (gtest binary installed undershare/, install-timeCTestTestfile.cmake+COMPONENT_OVERRIDEStest_dir).Changes
projects/amdsmi/tests/amd_smi_test/test_categories.yaml(new) —quick/standard/comprehensive/fullcategories with a shared_common_excludesanchor and per-archexclude_gpublocks (ex_gpu_gfx90a,ex_gpu_gfx110X,ex_gpu_gfx103X). Patterns/excludes mirror the legacyTheRock/build_tools/github_actions/test_executable_scripts/test_amdsmi.pyfilters andamdsmitst.exclude.projects/amdsmi/CMakeLists.txt— setROCM_SYSTEMS_ROOT(guarded) soshared/ctestcan be located.projects/amdsmi/tests/amd_smi_test/CMakeLists.txt— includeshared/ctest/TestCategories.cmake(guarded), callapply_test_category_labels(amdsmitst ...), and install the generatedCTestTestfile.cmaketoshare/amd_smi/tests/ctest/. It is installed one directory below theamdsmitstbinary so the parser's relative../amdsmitstpath resolves. Guarded onshared/ctestso standalone / sparse checkouts keep building.therock-*.ymlworkflows atusers/dravindr/tr_amdsmiso the build+test use the paired TheRock changes.Notes
CTestTestfile.cmakeundershare/amd_smi/tests/ctest/) already ship in thecore-amdsmi_runartifact via the existingshare/amd_smi/**glob, which--base-onlyfetches.Verification (local)
ctest -N(13 suites),ctest --print-labels,ctest -L ^quick$, and generic-vs-gfx90alabel selection all behave correctly.--installplacesCTestTestfile.cmakeatshare/amd_smi/tests/ctest/.The 7 TheRock workflow refs currently point at
users/dravindr/tr_amdsmi. Revert them to a pinnedROCm/TheRockSHA once the pairedtr_amdsmiPR merges.Made with Cursor