Skip to content

Add test filter standardisation for amdsmi#6784

Draft
dileepr1 wants to merge 3 commits into
mainfrom
users/dravindr/tr_amdsmi
Draft

Add test filter standardisation for amdsmi#6784
dileepr1 wants to merge 3 commits into
mainfrom
users/dravindr/tr_amdsmi

Conversation

@dileepr1

Copy link
Copy Markdown
Contributor

Summary

Paired TheRock side of test-filter standardization for amdsmi. Switches the amdsmi test job to the generic test_runner.py so ctest -L {quick|standard|comprehensive|full} drives the amdsmitst gtest suite from the installed tree.

Pairs with rocm-systems PR ROCm/rocm-systems#8995 (branch users/dravindr/tf_amdsmi), which adds test_categories.yaml and installs share/amd_smi/tests/ctest/CTestTestfile.cmake via apply_test_category_labels().

Changes

  • build_tools/github_actions/fetch_test_configurations.py — amdsmi test_scripttest_runner.py.
  • build_tools/github_actions/test_executable_scripts/test_runner.py — add a COMPONENT_OVERRIDES["amdsmi"] entry with test_dir = share/amd_smi/tests/ctest. The amdsmitst binary installs under share/amd_smi/tests, and the generated CTestTestfile.cmake lives one directory below it so its relative ../amdsmitst path resolves.
  • rocm-systems submodule — bumped to the tip of users/dravindr/tf_amdsmi (ROCm/rocm-systems@53a45d9e), and .gitmodules branch updated accordingly, so CI builds amdsmi with the install-time CTest categories.

Notes

  • No artifact-*.toml change needed: the amdsmitst binary and the generated CTestTestfile.cmake already ship in core-amdsmi_run via the existing share/amd_smi/** glob, which the amdsmi test job fetches with --base-only.
  • The legacy test_amdsmi.py is left in place (its filters/excludes are the source for the new test_categories.yaml).

Verification (local)

  • unit_test_runner.py: 30/30 pass.
  • Resolved TEST_DIR for TEST_COMPONENT=amdsmi is .../share/amd_smi/tests/ctest.
  • Simulated install-tree ctest --print-labels / ctest -L ^quick$ and generic-vs-gfx90a label selection all behave correctly.

⚠️ WIP before merge

The rocm-systems submodule is pinned to the tf_amdsmi branch tip. Revert it to a rocm-systems develop SHA once ROCm/rocm-systems#8995 merges.

Made with Cursor

dileepr1 and others added 2 commits July 22, 2026 08:36
Pairs with the rocm-systems branch users/dravindr/tf_amdsmi, which
installs share/amd_smi/tests/ctest/CTestTestfile.cmake via
apply_test_category_labels() with quick/standard/comprehensive/full
category labels for the amdsmitst gtest suite.

- fetch_test_configurations.py: switch amdsmi test_script to
  test_runner.py so the generic runner drives ctest using the
  category labels.
- test_runner.py: add a COMPONENT_OVERRIDES entry pointing ctest at
  share/amd_smi/tests/ctest (the amdsmitst binary installs under
  share/amd_smi/tests, and the generated CTestTestfile lives one dir
  below it so its relative "../amdsmitst" path resolves).

No artifact-toml change needed: the amdsmitst binary and the generated
CTestTestfile already ship in core-amdsmi_run via the share/amd_smi/**
glob, which --base-only fetches.

Co-authored-by: Cursor <cursoragent@cursor.com>
Bump the rocm-systems submodule to the tip of the paired branch
users/dravindr/tf_amdsmi (ROCm/rocm-systems@53a45d9e), which adds the
amdsmi test_categories.yaml and installs
share/amd_smi/tests/ctest/CTestTestfile.cmake via
apply_test_category_labels(). This lets TheRock CI build amdsmi with
the install-time CTest categories so test_runner.py can run
`ctest -L <category>`.

WIP: revert the submodule pin to a rocm-systems develop SHA once the
tf_amdsmi PR (ROCm/rocm-systems#8995) merges.

Co-authored-by: Cursor <cursoragent@cursor.com>
@therock-pr-bot

therock-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 22, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	rocm-systems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant