Add test filter standardisation for amdsmi#6784
Draft
dileepr1 wants to merge 3 commits into
Draft
Conversation
Pairs with the rocm-systems branch users/dravindr/tf_amdsmi, which installs share/amd_smi/tests/ctest/CTestTestfile.cmake via apply_test_category_labels() with quick/standard/comprehensive/full category labels for the amdsmitst gtest suite. - fetch_test_configurations.py: switch amdsmi test_script to test_runner.py so the generic runner drives ctest using the category labels. - test_runner.py: add a COMPONENT_OVERRIDES entry pointing ctest at share/amd_smi/tests/ctest (the amdsmitst binary installs under share/amd_smi/tests, and the generated CTestTestfile lives one dir below it so its relative "../amdsmitst" path resolves). No artifact-toml change needed: the amdsmitst binary and the generated CTestTestfile already ship in core-amdsmi_run via the share/amd_smi/** glob, which --base-only fetches. Co-authored-by: Cursor <cursoragent@cursor.com>
Bump the rocm-systems submodule to the tip of the paired branch users/dravindr/tf_amdsmi (ROCm/rocm-systems@53a45d9e), which adds the amdsmi test_categories.yaml and installs share/amd_smi/tests/ctest/CTestTestfile.cmake via apply_test_category_labels(). This lets TheRock CI build amdsmi with the install-time CTest categories so test_runner.py can run `ctest -L <category>`. WIP: revert the submodule pin to a rocm-systems develop SHA once the tf_amdsmi PR (ROCm/rocm-systems#8995) merges. Co-authored-by: Cursor <cursoragent@cursor.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # rocm-systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired TheRock side of test-filter standardization for amdsmi. Switches the amdsmi test job to the generic
test_runner.pysoctest -L {quick|standard|comprehensive|full}drives theamdsmitstgtest suite from the installed tree.Pairs with rocm-systems PR ROCm/rocm-systems#8995 (branch
users/dravindr/tf_amdsmi), which addstest_categories.yamland installsshare/amd_smi/tests/ctest/CTestTestfile.cmakeviaapply_test_category_labels().Changes
build_tools/github_actions/fetch_test_configurations.py— amdsmitest_script→test_runner.py.build_tools/github_actions/test_executable_scripts/test_runner.py— add aCOMPONENT_OVERRIDES["amdsmi"]entry withtest_dir = share/amd_smi/tests/ctest. Theamdsmitstbinary installs undershare/amd_smi/tests, and the generatedCTestTestfile.cmakelives one directory below it so its relative../amdsmitstpath resolves.rocm-systemssubmodule — bumped to the tip ofusers/dravindr/tf_amdsmi(ROCm/rocm-systems@53a45d9e), and.gitmodulesbranch updated accordingly, so CI builds amdsmi with the install-time CTest categories.Notes
artifact-*.tomlchange needed: theamdsmitstbinary and the generatedCTestTestfile.cmakealready ship incore-amdsmi_runvia the existingshare/amd_smi/**glob, which the amdsmi test job fetches with--base-only.test_amdsmi.pyis left in place (its filters/excludes are the source for the newtest_categories.yaml).Verification (local)
unit_test_runner.py: 30/30 pass.TEST_DIRforTEST_COMPONENT=amdsmiis.../share/amd_smi/tests/ctest.ctest --print-labels/ctest -L ^quick$and generic-vs-gfx90alabel selection all behave correctly.The
rocm-systemssubmodule is pinned to thetf_amdsmibranch tip. Revert it to a rocm-systemsdevelopSHA once ROCm/rocm-systems#8995 merges.Made with Cursor