Skip to content

fix(clr): Use rocr backend for HIP/OCL by default#8900

Draft
agunashe wants to merge 3 commits into
developfrom
users/agunashe/rocr_default
Draft

fix(clr): Use rocr backend for HIP/OCL by default#8900
agunashe wants to merge 3 commits into
developfrom
users/agunashe/rocr_default

Conversation

@agunashe

@agunashe agunashe commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Motivation

Use rocr by default to see if we pass all tests

Technical Details

Use rocr by default to see if we pass all tests

Issue Tracking

JIRA ID: ROCM-20431

Test Plan

hip-tests with GPU_ENABLE_PAL=0 passing and all component tests on Rock pass

Test Result

hip-tests with GPU_ENABLE_PAL=0 passing and all component tests on Rock pass

Submission Checklist

@agunashe
agunashe requested a review from a team as a code owner July 20, 2026 23:50
Copilot AI review requested due to automatic review settings July 20, 2026 23:50
@therock-pr-bot

therock-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/clr/rocclr/device/device.cpp, projects/clr/rocclr/utils/flags.hpp, projects/hip-tests/catch/unit/env/hipEnvGpuEnablePal.cc; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes ROCclr’s default backend selection so HIP/OCL prefer the ROCr backend (including on Windows), primarily to evaluate overall test pass rate under ROCr-by-default behavior.

Changes:

  • Set the default GPU_ENABLE_PAL flag value to prefer ROCr.
  • Update Windows-specific backend defaulting logic in Device::init() to choose ROCr when the flag is untouched.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
projects/clr/rocclr/utils/flags.hpp Changes the default value of GPU_ENABLE_PAL, affecting which backend is selected when users don’t set the flag.
projects/clr/rocclr/device/device.cpp Updates Windows defaulting logic so the ROCr backend is selected by default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread projects/clr/rocclr/utils/flags.hpp
Comment thread projects/clr/rocclr/device/device.cpp Outdated
Comment thread projects/clr/rocclr/device/device.cpp Outdated
@agunashe
agunashe marked this pull request as draft July 21, 2026 00:10
agunashe and others added 2 commits July 21, 2026 12:50
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants