fix(clr): Use rocr backend for HIP/OCL by default#8900
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
There was a problem hiding this comment.
Pull request overview
This PR changes ROCclr’s default backend selection so HIP/OCL prefer the ROCr backend (including on Windows), primarily to evaluate overall test pass rate under ROCr-by-default behavior.
Changes:
- Set the default
GPU_ENABLE_PALflag value to prefer ROCr. - Update Windows-specific backend defaulting logic in
Device::init()to choose ROCr when the flag is untouched.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/clr/rocclr/utils/flags.hpp | Changes the default value of GPU_ENABLE_PAL, affecting which backend is selected when users don’t set the flag. |
| projects/clr/rocclr/device/device.cpp | Updates Windows defaulting logic so the ROCr backend is selected by default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Motivation
Use rocr by default to see if we pass all tests
Technical Details
Use rocr by default to see if we pass all tests
Issue Tracking
JIRA ID: ROCM-20431
Test Plan
hip-tests with GPU_ENABLE_PAL=0 passing and all component tests on Rock pass
Test Result
hip-tests with GPU_ENABLE_PAL=0 passing and all component tests on Rock pass
Submission Checklist