Skip to content

Change HIP to use default GPU_ENABLE_PAL=0 (Rocr backend)#6713

Draft
agunashe wants to merge 1 commit into
mainfrom
users/agunashe/rocr_default_hip
Draft

Change HIP to use default GPU_ENABLE_PAL=0 (Rocr backend)#6713
agunashe wants to merge 1 commit into
mainfrom
users/agunashe/rocr_default_hip

Conversation

@agunashe

@agunashe agunashe commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Motivation

Use Rocr backend for HIP/OCL

Includes rocm-systems PR which changes default to use ROCr
ROCm/rocm-systems#8900

Technical Details

Use Rocr backend for HIP/OCL

Test Plan

All Rock tests pass and all hip-tests pass

Test Result

All Rock tests pass and all hip-tests pass

Submission Checklist

@agunashe
agunashe requested a review from a team as a code owner July 21, 2026 00:09
@agunashe
agunashe marked this pull request as draft July 21, 2026 00:09
@therock-pr-bot

therock-pr-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 21, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@ScottTodd

Copy link
Copy Markdown
Member

What's the plan here? I see that this is a draft PR, but this (using PAL vs ROCR on Windows) looks like it should be using a feature flag:

cc @astyrrian1

@agunashe

Copy link
Copy Markdown
Contributor Author

I see that this is a draft PR, but this (using PAL vs ROCR on Windows) looks like it should be using a feature flag:

This is to test ROCr backend as default at runtime. Changes here make sure components use GPU_ENABLE_PAL=0 env variable correctly to validate ROCr backend.
The feature flags mentioned by you are build flags not runtime flags.
I want to keep the current build setup (build both PAL/ROCr) unchanged, but just test the runtime behavior by setting ROCr as default backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants