[hipthreads] Add hipThreads build recipe and artifact to TheRock by marsavicc · Pull Request #6769 · ROCm/TheRock

marsavicc · 2026-07-22T11:39:40Z

Motivation

Onboard hipThreads (GPU-side std::thread-style concurrency library, now living in rocm-libraries) into TheRock so it builds as part of ROCm.

Technical Details

Add the hipthreads build recipe in math-libs/CMakeLists.txt, pulling source from ${THEROCK_ROCM_LIBRARIES_SOURCE_DIR}/projects/hipthreads.
Register [artifacts.hipthreads] in BUILD_TOPOLOGY.toml (target-neutral: the static libhipthreads.a is identical across architectures) and add math-libs/artifact-hipthreads.toml.
Register libhipcxx as a CMake package provider so hipThreads can find_package(libhipcxx) (hipThreads is the first consumer of it this way).
Build with -DDISABLE_WERROR=ON (HIP runtime headers trip hipThreads' strict warnings) and document the new THEROCK_ENABLE_HIPTHREADS flag.

Test Plan

Build hipThreads via TheRock against rocm-libraries.

Test Result

Builds succesfully and produces the hipthreads artifact.

Note: CI is red until the TheRock rocm-libraries submodule is bumped to a SHA that includes projects/hipthreads (migration landed after the current pin).

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.

therock-pr-bot · 2026-07-22T11:40:37Z

❌ PR Check — Action Required

Check	Status	Details
🌿 Branch Name	✅ Pass	—
📝 PR Title/Description	❌ Fail	Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword. Expected: include a `JIRA ID` / `ISSUE ID` line (separator `:` or `-`, or omitted; value may be a JIRA key, a number with/without `#`, or a link), OR a closing keyword + issue reference. Accepted examples: • `JIRA ID : TESTAUTO-6039` • `JIRA ID - #330` • `JIRA ID #330` • `JIRA ID` (on separate line) `ROCM-25757` • `ISSUE ID : TESTUTO-3334` • `ISSUE ID #3334` • `ISSUE ID - TESTAUTO-3433` • `ISSUE ID` (on separate line) `AIRUNTIME-2352` • `ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234` • `Closes #10` • `Fixes octo-org/octo-repo#100` • `Resolves: #123` • `#123` • `https://github.com/<org_name>/<repo_name>/issues/123` Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	PR does not contain code files — Unit Test auto-passed
🔎 pre-commit	❌ Fail	Error: Check concluded with `failure`.
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

❌ PR Title/Description

❌ pre-commit

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

therock-pr-bot · 2026-07-22T11:40:38Z

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

marbre

Some initial feedback.

marbre · 2026-07-22T12:07:50Z

+[components.lib."math-libs/hipthreads/stage"]
+optional = true
+[components.dbg."math-libs/hipthreads/stage"]
+optional = true


Why those are marked optional? I think we can drop those if empty.

The static lib lands in dev, so lib/dbg were empty. I'll drop both.

marbre · 2026-07-22T12:07:54Z

+  # Make libhipcxx's CMake package resolvable by dependents (e.g. hipthreads)
+  # via find_package(libhipcxx).


Suggested change

# Make libhipcxx's CMake package resolvable by dependents (e.g. hipthreads)

# via find_package(libhipcxx).

marbre · 2026-07-22T12:09:07Z

+    # on therock_provide_artifact below) so per-arch CI upload races are harmless.
+    USE_TEST_AMDGPU_TARGETS
+    DEFAULT_GPU_TARGETS
+      gfx1201  # Fixes issue with empty target list for unsupported architectures.


Why do we pick gfx1201 here? This needs an public issue, linked here instead of the comment.

This was copied from the libhipcxx recipe (I looked up that PR for reference), but hipthreads supports all architectures and is never in EXCLUDE_TARGET_PROJECTS, so the DEFAULT_GPU_TARGETS fallback never fires for us.

Removed it rather than link an issue for a workaround we don't need.

marbre · 2026-07-22T12:09:34Z

+      -DHIP_PLATFORM=amd
+      -DROCM_PATH=
+      -DROCM_DIR=
+      -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON # Needed for Ninja build?


Suggested change

-DCMAKE_BUILD_WITH_INSTALL_RPATH=ON # Needed for Ninja build?

-DCMAKE_BUILD_WITH_INSTALL_RPATH=ON

Why this comment? What do you need to know?

I think it was copied from some libhipcxx PRs that I was looking at as a reference and I forgot to remove it.

marbre · 2026-07-22T12:10:36Z

+      rocm-cmake
+      libhipcxx
+    RUNTIME_DEPS
+      amd-llvm


Why does this require amd-llvm as a runtime dep?

The static lib embeds device code and HIP fatbin symbols, so consumers link through amd-llvm's clang++/ld.lld (--hip-link). A host-only linker can't resolve it, so amd-llvm is a real consume-time dep (same as libhipcxx).

marbre · 2026-07-22T12:12:43Z

+# identical across per-arch shards. Built for all targets once (see
+# USE_TEST_AMDGPU_TARGETS in math-libs/CMakeLists.txt) and published as a single
+# _generic artifact, making per-arch CI upload races harmless (latest write wins).


Suggested change

# identical across per-arch shards. Built for all targets once (see

# USE_TEST_AMDGPU_TARGETS in math-libs/CMakeLists.txt) and published as a single

# _generic artifact, making per-arch CI upload races harmless (latest write wins).

# identical across per-arch shards. Built for all targets once.

marbre · 2026-07-22T12:13:27Z

+  "hipthreads/**/*",
+]
+exclude = [
+  # Exclude folders not needed for testing


Suggested change

# Exclude folders not needed for testing

That comment is not needed.

github-project-automation Bot added this to TheRock Triage Jul 22, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Jul 22, 2026

marsavicc requested review from ammallya and marbre July 22, 2026 11:39

therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 22, 2026

marsavicc mentioned this pull request Jul 22, 2026

[hipthreads] Add hipThreads lit and example-app test jobs to TheRock CI #6770

Open

1 task

marsavicc added 3 commits July 22, 2026 15:26

Provide libhipcxx CMake package for find_package consumers

1166992

Add hipthreads build recipe and artifact descriptor

0ca8fba

Document hipthreads integration

f8095b9

marbre reviewed Jul 22, 2026

View reviewed changes

marsavicc added 3 commits July 22, 2026 20:52

Drop empty lib/dbg components from hipthreads artifact

58ce08d

Address review comments: trim comments, drop empty artifact components

c3bac03

Remove unused DEFAULT_GPU_TARGETS from CMakeLists.txt

a946d94

		# Make libhipcxx's CMake package resolvable by dependents (e.g. hipthreads)
		# via find_package(libhipcxx).

	-DCMAKE_BUILD_WITH_INSTALL_RPATH=ON # Needed for Ninja build?
	-DCMAKE_BUILD_WITH_INSTALL_RPATH=ON

Uh oh!

Conversation

marsavicc commented Jul 22, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

therock-pr-bot Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ PR Check — Action Required

Uh oh!

therock-pr-bot Bot commented Jul 22, 2026

Uh oh!

marbre left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marsavicc commented Jul 22, 2026 •

edited by atlassian Bot

Loading

therock-pr-bot Bot commented Jul 22, 2026 •

edited

Loading