[hipthreads] Add hipThreads lit and example-app test jobs to TheRock CI#6770
Open
marsavicc wants to merge 2 commits into
Open
[hipthreads] Add hipThreads lit and example-app test jobs to TheRock CI#6770marsavicc wants to merge 2 commits into
marsavicc wants to merge 2 commits into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Pre-commit check failed⛔ pre-commit failed Please run locally:
This repo uses |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JIRA ID : ROCM-23943
Run hipThreads' lit unit tests and example apps in TheRock CI on Linux and Windows. Depends on the hipThreads build PR #6769 .
Technical Details
test_hipthreads.py(runs the lit suite) andtest_hipthreads_examples.py(builds + runs saxpy, InOneWeekend, and spmm against the packaged artifact via find_package).hipthreadsandhipthreads_examplesjobs infetch_test_configurations.py(linux + windows) and add the--hipthreadsfetch flag toinstall_rocm_from_artifacts.py.HIPTHREADS_VCORES_PER_WGP=1at test runtime so the scheduler doesn't over-subscribe shared CI GPUs (runtime setting; the shipped library keeps its default).Test Plan
Run both scripts against a built artifact with
OUTPUT_ARTIFACTS_DIR/THEROCK_BIN_DIRset, on Linux and Windows.Test Result
lit suite and all three example apps pass on Linux and Windows.
Submission Checklist