Skip to content

[hipthreads] Add hipThreads lit and example-app test jobs to TheRock CI#6770

Open
marsavicc wants to merge 2 commits into
mainfrom
users/marsavic/hipthreads-therock-test
Open

[hipthreads] Add hipThreads lit and example-app test jobs to TheRock CI#6770
marsavicc wants to merge 2 commits into
mainfrom
users/marsavic/hipthreads-therock-test

Conversation

@marsavicc

@marsavicc marsavicc commented Jul 22, 2026

Copy link
Copy Markdown

Motivation

JIRA ID : ROCM-23943

Run hipThreads' lit unit tests and example apps in TheRock CI on Linux and Windows. Depends on the hipThreads build PR #6769 .

Technical Details

  • Add test_hipthreads.py (runs the lit suite) and test_hipthreads_examples.py (builds + runs saxpy, InOneWeekend, and spmm against the packaged artifact via find_package).
  • Register the hipthreads and hipthreads_examples jobs in fetch_test_configurations.py (linux + windows) and add the --hipthreads fetch flag to install_rocm_from_artifacts.py.
  • Set HIPTHREADS_VCORES_PER_WGP=1 at test runtime so the scheduler doesn't over-subscribe shared CI GPUs (runtime setting; the shipped library keeps its default).

Test Plan

Run both scripts against a built artifact with OUTPUT_ARTIFACTS_DIR / THEROCK_BIN_DIR set, on Linux and Windows.

Test Result

lit suite and all three example apps pass on Linux and Windows.

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ❌ Fail Error: Check concluded with failure.
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ pre-commit

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

Pre-commit check failed

pre-commit failed

Please run locally:

  • python -m pip install pre-commit
  • pre-commit install
  • pre-commit run --all-files --show-diff-on-failure

This repo uses .pre-commit-config.yaml.

@marbre
marbre requested review from geomin12 and removed request for marbre July 22, 2026 15:28
@marbre

marbre commented Jul 22, 2026

Copy link
Copy Markdown
Member

Leaving the second round of review (after @ammallya reviewed and approved) as well as the final approval to @geomin12 who is more into testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants