makefiles/tools: enhance miniterm path finding in serial.inc.mk [backport 2026.04]#22219
Conversation
|
Please rebase :) |
d013034 to
c9fa913
Compare
c9fa913 to
58a4609
Compare
|
My brain instantly rebased based on master, we, ofc, don't want to rebase on master here. Fixed now 👍 |
|
Crasbe doesn't want this to be merged 🤨 |
|
We'll have to queue this manually once the next PR on the |
|
Oh, Murdock can't handle multiple merge queues? |
Yes and no, since this is on a different branch, both will be in the Murdock list and GitHub counts that as "running". With our current CI situation, having two merges running at the same time will result in the second merge being cancelled due to inactivity after 6 hours. So this PR will have to be added manually to the merge queue so that we don't hit that 6h limit, so around ~2 hours after the first merge started. |
|
That's what I did yesterday/tonight with the Docker PR too before going to sleep 😴 |
True commitment to the craft |
Backport of #22208
Contribution description
Apparently
minitermlikes to change the executable name. In very old versions it wasminiterm.py, then it wasminitermand now (version 3.5 and higher) it ispyserial-miniterm.This change enhances the path discovery to select the right one.
Testing procedure
Make sure you have (a recent version of) pyserial installed:
Run your favorite application with
RIOT_TERMINAL=miniterm.Behavior on
master:Behavior with this PR:
Issues/PRs references
Found while testing #22207.
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: