makefiles/tools: enhance miniterm path finding in serial.inc.mk#22208
Merged
Conversation
AnnsAnns
reviewed
Apr 22, 2026
Contributor
Author
|
I also added some information about the correct miniterm in the Guides now :) |
crasbe
requested review from
MichelRottleuthner,
gschorcht and
leandrolanzieri
as code owners
April 22, 2026 13:02
Contributor
Author
|
Also unified the references to |
AnnsAnns
reviewed
Apr 22, 2026
AnnsAnns
left a comment
Member
There was a problem hiding this comment.
Feel free to squash after this change 👍
kfessel
reviewed
Apr 23, 2026
AnnsAnns
approved these changes
Apr 23, 2026
AnnsAnns
enabled auto-merge
April 23, 2026 09:56
Member
|
ty for looking into this 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Apparently
minitermlikes to change the executable name. In very old versions it wasminiterm.py, then it wasminitermand now (version 3.5 and higher) it ispyserial-miniterm.This change enhances the path discovery to select the right one.
Testing procedure
Make sure you have (a recent version of) pyserial installed:
Run your favorite application with
RIOT_TERMINAL=miniterm.Behavior on
master:Behavior with this PR:
Issues/PRs references
Found while testing #22207.
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: