Skip to content

feat: bind IBKR order outcomes to reconciliation keys - #454

Closed
Pigbibi wants to merge 2 commits into
mainfrom
codex/p2-order-event-consumer-binding-20260902
Closed

feat: bind IBKR order outcomes to reconciliation keys#454
Pigbibi wants to merge 2 commits into
mainfrom
codex/p2-order-event-consumer-binding-20260902

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • offline contract wiring only: preserve one privacy-safe IBKR key across submit, open-order, and execution observations
  • derive partial fills from pinned ib_insync.OrderStatus plus cumulative filled quantity; PendingCancel remains non-terminal
  • write the existing create-only QPK record_outcome only when every keyed order is truly terminal (Filled, Cancelled, or ApiCancelled); pending/partial observations remain in local reconciliation evidence
  • fail closed when a terminal outcome write returns false or raises; no submission, funding, position, or retry behavior is changed
  • retain legacy reconciliation digest compatibility by excluding new order-event metadata from the existing open-order/execution baseline digests; no baseline is re-enrolled or changed
  • rebased onto main merge commit 6d4705639ef630f4474949caeec2ecfccd8fe169; preserve test: repair P1 legacy suite baseline #455 strict full-suite CI and its unsuppressed full-suite contract

Safety boundary

  • no broker/provider/replay/order calls
  • no Cloud Run, Scheduler, deployment, or workflow dispatch
  • no QuantPlatformKit, dependency, manifest, or lockfile changes

Validation

  • P2 focused tests: 81 passed
  • Ruff, uv lock --check, git diff --check, and actionlint: passed
  • GitHub CI run 33717024970: passed, including the strict full test suite without || true, continue-on-error, or added ignore rules.

Rebase resolution

  • kept test: repair P1 legacy suite baseline #455 ci.yml, tests/__init__.py, and strict full-suite test contract
  • dropped the superseded temporary scoped-P2 / legacy-full-suite split job commit
  • retained P2 business implementation and regression tests only.

Pigbibi and others added 2 commits September 3, 2026 12:55
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi force-pushed the codex/p2-order-event-consumer-binding-20260902 branch from 83c18aa to d07d54d Compare September 3, 2026 04:58
@Pigbibi Pigbibi closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant