feat: enforce canonical IBKR order identity - #456
Closed
Pigbibi wants to merge 1 commit into
Closed
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
force-pushed
the
codex/canonical-order-key-contract-20260903
branch
from
September 3, 2026 07:28
c07578c to
dc577a0
Compare
Collaborator
Author
|
Closing unmerged under CC2: the frozen head dc577a0 was blocked by the independent semantic acceptance. Canonical identity can be absent while reconciliation reports executed, and mixed identity failure does not take fail-closed precedence. Per the frozen-head rule, no post-review patch is permitted on this PR. A successor, if approved, must address only these invariants with adversarial tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ib-insync==0.9.86: positiveorderIduses account/client/order; non-positive manual orders use account/permIdReconciliationRequired/order_identity_unavailablewhen identity cannot be normalized, and prevent upstream execution summaries from reporting successThis is a new slice from
6d4705639ef630f4474949caeec2ecfccd8fe169; no implementation code was reused from closed PR #454.Scope boundaries
Tests
executed66 passed: focused reconciliation/submission/execution-service tests430 passed, 5 skipped: repository practical CI test scoperuff check --exclude external .: passeduv lock --check: passedgit diff --check: passedAn unfiltered local test run exposed 11 failures only in the repository's already-excluded
tests/test_request_handling.py; the exact base commit reproduced the same 11 failures. This PR does not change those exclusions or unrelated fixtures.Compatibility risk
RECONCILE_ONLYReconciliationRequiredinstead of being treated as successful