Skip to content

fix: claim Firstrade live runs atomically before orders - #249

Merged
Pigbibi merged 1 commit into
mainfrom
fix/firstrade-durable-live-claim
Aug 24, 2026
Merged

fix: claim Firstrade live runs atomically before orders#249
Pigbibi merged 1 commit into
mainfrom
fix/firstrade-durable-live-claim

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Adds a durable, create-only live execution claim before any Firstrade order submission.

  • GCS claim uses create_text(..., if_generation_match=0) through create_json
  • claim is permanent and fail-closed: an unknown/interrupted submission remains blocked
  • duplicate claim returns no-order terminal response
  • dry-run paths are unchanged
  • no broker credentials, live permissions, or order calls are changed

Tests: FirstradePlatform/.venv/bin/python -m pytest -q FirstradePlatform/tests/test_strategy_run_claim.py FirstradePlatform/tests/test_rebalance_service.py (24 passed).

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi force-pushed the fix/firstrade-durable-live-claim branch from 1e7c7f3 to 08e03c7 Compare August 24, 2026 03:09
@Pigbibi
Pigbibi merged commit eeae241 into main Aug 24, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix/firstrade-durable-live-claim branch August 24, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant