Skip to content

fix: use GCS generation precondition for Firstrade claims - #251

Merged
Pigbibi merged 1 commit into
mainfrom
fix/firstrade-gcs-atomic-claim
Aug 24, 2026
Merged

fix: use GCS generation precondition for Firstrade claims#251
Pigbibi merged 1 commit into
mainfrom
fix/firstrade-gcs-atomic-claim

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Why

The live execution claim introduced in PR 249 calls an object-store create_text method that is not in the pinned QuantPlatformKit contract. This fails closed before order submission, but prevents valid live cycles.

Change

  • use GCS if_generation_match=0 directly for create-only claim writes
  • return false only when the claim already exists
  • retain fail-closed behavior for other storage errors

Verification

  • targeted strategy-claim and rebalance tests passed
  • git diff whitespace check passed

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit a2851b4 into main Aug 24, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix/firstrade-gcs-atomic-claim branch August 24, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant