Skip to content

refactor: secure deserialization of file header #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepsource-dev-autofix wants to merge 1 commit into
base: v1.18.1-base
Choose a base branch
from
Open

refactor: secure deserialization of file header #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions include/cli/modules/file.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ function run($args, $options) {
$this->stderr->write('IOError: '.$e->getMessage());
}
}
$this->stdout->write("Migrated $count files\n");
$this->stdout->write("Migrated $count files
");
break;

/**
Expand Down Expand Up @@ -289,9 +290,13 @@ function run($args, $options) {
if (strlen($header) != $hlen)
$this->fail('Short read getting header info');

$header = unserialize($header);
if (!$header)
// Deserialize header with restricted classes and validate structure
$header = unserialize($header, ['allowed_classes' => false]);
if ($header === false)
$this->fail('Unable to decipher file header');
if (!is_array($header) || !isset($header['file']) || !is_array($header['file'])) {
$this->fail('Invalid file header');
}

// Find or create the file record
$finfo = $header['file'];
Expand Down