refactor: secure deserialization of file header - #10
Open
deepsource-dev-autofix[bot] wants to merge 1 commit into
Open
refactor: secure deserialization of file header#10deepsource-dev-autofix[bot] wants to merge 1 commit into
deepsource-dev-autofix[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements two key changes:
Changes by issue:
• Deserialization of Untrusted Data
• Issue: Unrestricted calls to PHP’s unserialize() can lead to code injection or object instantiation vulnerabilities when processing attacker-controlled data.
• Fix: We now call unserialize($header, ['allowed_classes' => false]) to disable all class instantiation during deserialization, and we explicitly check that the result is a valid array containing a 'file' key holding an array. If validation fails, the process is aborted with a clear error. This configuration setting (
allowed_classes => false) was chosen under the assumption that no object graphs are required; please review and adjust if your application relies on specific classes being restored.