Skip to content

Implements SUB and SUBS instructions.#16

Merged
begeistert merged 4 commits into
masterfrom
feat/sub
Feb 2, 2026
Merged

Implements SUB and SUBS instructions.#16
begeistert merged 4 commits into
masterfrom
feat/sub

Conversation

@lmSeryi

@lmSeryi lmSeryi commented Feb 1, 2026

Copy link
Copy Markdown
Collaborator

Adds support for SUB (subtract) and SUBS (subtract with flags) instructions, including variants for immediate values and register operands.

This expands the instruction set and enhances the arithmetic capabilities of the CPU.

Description

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧹 Refactoring (no functional changes, just code cleanup)

Checklist

  • 🧪 Tests passed locally (dotnet test)
  • ✅ Added new tests for this feature/fix
  • 📝 Documentation updated (if applicable)
  • 🚫 No "Magic Strings" or hardcoded values
  • 💾 Validated against the RP2040 Datasheet (if applicable)

Screenshots / Hex Dumps (Optional)

Adds support for SUB (subtract) and SUBS (subtract with flags) instructions, including variants for immediate values and register operands.

This expands the instruction set and enhances the arithmetic capabilities of the CPU.
@lmSeryi
lmSeryi requested a review from begeistert as a code owner February 1, 2026 23:27
@sonarqubecloud

sonarqubecloud Bot commented Feb 2, 2026

Copy link
Copy Markdown

@begeistert
begeistert merged commit 1b3806b into master Feb 2, 2026
2 checks passed
@begeistert
begeistert deleted the feat/sub branch February 2, 2026 06:50
@begeistert begeistert linked an issue Feb 2, 2026 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT|CPU|ISA] Implement SUB and SUBS Instructions

2 participants