Proposal G, PR4b: passphrase UX, My Decks page, save/load wiring

[WilfordGrimley]

Description

The frontend UI half of Proposal G (docs/proposals/proposal-g-user-accounts-saved-decks.md), per its zero-knowledge amendment (§8) and frontend spec (§4). This is PR4b in the sequencing from the original build-go task - the last piece of the originally-requested 4-part build (split into 5 once the crypto module got its own PR).

Dependency note (base branch): this branch was originally based directly on master (not stacked on the other open Proposal G PRs) specifically to avoid the stacked-PR base-deletion trap (docs/lessons.md) - which did in fact hit the original API PR (#88, auto-closed when its base branch was deleted on #85's squash-merge). Two independent recovery attempts landed: #94 (merged) and #95 (closed as a duplicate by the owner once the collision was noticed). Since #85, #86, #89, and #94 have now all merged to master, and this PR's base is the master branch ref (not a fixed commit), its diff has already naturally shrunk to just this PR's own genuinely new content - no rebase needed.

What's here

• Crypto session (features/savedDecks/cryptoSession.tsx): a plain React Context (not Redux - CryptoKey isn't serializable) holding the in-memory master key and status (anonymous/loading/no-profile/locked/unlocked), wired to the crypto-profile endpoints. Mounted in Layout.tsx.
• 7 RTK Query endpoints in store/api.ts (SavedDecks/CryptoProfile cache tags, credentials: "include" + CSRF header matching the moderation-write convention).
• Passphrase creation + unlock modals: PassphraseSetupModal (first save, verbatim-spirit unrecoverability warning), RecoveryKeyDisplay (show-once download/print/copy + acknowledge gate, shared by both flows), UnlockModal (once-per-session unlock, with a "Forgot your passphrase?" recovery branch that reissues a fresh recovery key).
• My Decks page (/myDecks): lists every saved deck, decrypted client-side; named decks and snapshots in separate groups; "Open in editor", per-deck delete, an explicit "Lock" action, and account reset (two-click confirm naming the exact deck count - reachable whether locked or unlocked, since its whole point is recovering access when unlock is impossible).
• Editor wiring: SavedDeckPanel (reverse breadcrumb + Save button, authenticated-only), SaveDeckModal (name prompt, local-file-slot warning), LoadSafetyModal (the loss-proof-by-construction load flow - dirty + logged-in always saves a safety copy first, offering "Update {name}" vs "Save as new snapshot" when the current content is itself an already-saved deck, or just an inline-renameable snapshot save when it wasn't), and the one-time anonymous→login adopt-by-save toast.

Deviations (with reasoning)

• get_saved_decks returns full per-deck ciphertext, not lightweight metadata - a deck's title lives inside the ciphertext under the ZK design, so there's no server-visible field for a lightweight list; the client decrypts every row to render "My Decks." An explicit, eyes-open tradeoff per §8's own exhaustive field enumeration, not something a title-only field would fix without violating that same enumeration.
• Local-file "honest re-pick placeholder" is the card grid's existing empty-slot/re-search UI, not a bespoke tile state - deviceLocal: true slots simply have no selectedImage on load, which the grid already renders as "pick an image" with the original search query intact. Avoids new UI surface for a case the app already handles.
• Account reset's "Discord-gated" requirement is satisfied by requiring an already-authenticated session (same as every other saved-deck action), not a fresh Discord re-auth redirect - the backend's post_reset_saved_decks has no freshness/recency check to justify one; a redirect step would be security theater without backend enforcement behind it.
• Anonymous→login adopt toast is informational only, pointing at the Save button, rather than an actionable "save now" button embedded in the toast itself - the existing Toasts system has no action-button support, and extending shared toast infra for this one caller wasn't worth it.

Own-caught bugs found while building this

1. PR4a's recovery flow never reissued a fresh recovery key, even though the ZK addendum's recovery flow explicitly re-wraps both slots (passphrase under the new passphrase, recovery under a fresh recovery key) once the old recovery key has actually been used - an ordinary passphrase change correctly leaves the recovery slot alone, but the full recovery path is a distinct case the crypto module didn't cover. Added rewrapMasterKeyWithNewRecoveryKey + extended the recovery-flow test to prove the new key works and the superseded old one doesn't.
2. cryptoSession.tsx's status fell through to "anonymous" whenever isAuthenticated was false - including the instant before the whoami query itself had even resolved. Caught via a genuine UnlockModal test failure (a misleading "wrong passphrase" error), not flakiness: a real click could slip through during that window and attempt to unlock/save a crypto profile before the authenticated check had settled. Fixed by giving whoami's own in-flight state a distinct "loading" status, with a regression test that delays the whoami response and asserts "loading" appears first.
3. A whole-project next lint pass (not run until the final verification step) caught two real simple-import-sort/imports errors in files that had each individually passed per-file lint checks earlier in the branch's history.

Checklist

• I have installed pre-commit and installed the hooks with pre-commit install before creating any commits.
• I have updated any related tests for code I modified or added new tests where appropriate.
• I have manually tested my changes as follows:
  • Full jest suite (380 tests, 39 suites) passing, tsc --noEmit clean, whole-project next lint clean (pre-existing warnings only), prettier --check clean.
  • 3 real-browser Playwright specs (tests/SavedDecks.spec.ts) run locally against a live dev server: the editor's Save action/breadcrumb render once signed in, the My Decks nav entry is hidden anonymously and appears once signed in, and the empty-state message renders correctly.
• I have updated any relevant documentation or created new documentation where appropriate.
  • No user-facing docs/wiki update yet - deferred until this lands, per this repo's CLAUDE.md convention of updating docs/wiki once there's real merged, user-facing behavior to describe. This is now the last piece of Proposal G left to merge.

---

Generated by Claude Code