What's That: replace the MTGAC applet with a compact link to the artist's MTGAC page - #733
Merged
Merged
Conversation
…mand The applet used to always stack a page-link button, up to five commerce buttons, a signature badge, and a credit line - never fewer than 2 rows, up to ~8. It's a same-origin link-out to our own cache-only backend endpoint, not a third-party embed. Default render is now one line: the artist page link plus a disclosure toggle. Commerce links, the signature badge, and the MTG Artist Connection credit move into a panel that mounts only once expanded - every link that existed before stays reachable, just not paid for in vertical space by default. The /editor rail's Artist section (ArtistSection.tsx) starts expanded via a new optional defaultExpanded prop: that surface is a dedicated accordion pane with room for the full applet, and its own Playwright coverage already asserts the credit line renders without interaction. Every other caller (question feed's inline credits, the card-detail modal's metadata table) is space-constrained next to whatever the surface is actually about, so it defaults collapsed. QuestionFeed.tsx and CardDetailedViewBody.tsx need no changes at all - both already call ArtistSupportLink with only artistName, which now composes correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArtistSupportLinkused to always stack a page-link button, up to five commerce buttons, a signature badge, and a credit line - never fewer than 2 rows, up to ~8. It's a same-origin link-out to this project's own cache-only backend endpoint, not a third-party embed (issue MTG Artist Connection data-endpoint integration #385's declined-embed posture is unaffected).chevron-down/chevron-up,aria-expanded). Commerce links, the signature badge, and the "Source: MTG Artist Connection" credit move into a panel that only mounts once the user expands it - every link that existed before is still reachable, just not paid for in vertical space by default.QuestionFeed.tsx(illustration-group credit and the confirmed-artist-vote credit),ArtistSection.tsx(/editorrail),CardDetailedViewBody.tsx(card-detail modal's metadata table). None of these files needed a code change exceptArtistSection.tsx.ArtistSection.tsx(the/editorrail's Artist accordion pane) opts into a new optionaldefaultExpandedprop so it starts open - that surface is a dedicated pane with room for the full applet, and its own Playwright coverage already asserted the credit line renders without interaction. Every other caller is space-constrained next to whatever the surface is actually about, so the default stays collapsed. This is a density prop on an existing component, not a new mechanism, so no separate doc ships with it.QuestionFeed.tsxitself is untouched - both its call sites already pass onlyartistName, which still composes correctly against the new default.Test plan
npx jest- 73 suites / 674 tests passingnpx playwright test- full suite (345 tests) run; only pre-existing, non-deterministic failures unrelated to this change (icon-font aria-snapshot rendering, phone-viewport scroll timing) - different failures on different runs, none touchingArtistSupportLink/question-feed/editor-artist-section coverageArtistSupportLink.spec.ts,DisplayPage.spec.ts:931, and the fullQuestionFeed.spec.ts(including a new test asserting the applet's expansion never overlaps the pinned reference image, per SPEC-wtc-rebuild.md's container-pinning amendment) all pass in isolation, repeatably/editorrail's Artist section starts expanded with the credit visible, matching prior behavior