ArtistSupportLink: drop redundant adjacent name labels, nest disclosure inside the button (#747) - #753
Merged
Merged
Conversation
…re inside the button (#747) The applet's own page-link button already names the artist (CompactLinkLabel); QuestionFeed's illustration/confirmed-artist credits and ArtistSection's Art-by line repeated it right next to the button. Removed the three redundant adjacent labels; the card-detail metadata table's row label already covers call site 4. The expansion panel was a sibling <div> of the collapsed link+toggle row, floating below the button rather than reading as part of it. It now nests inside that row's shell (CompactLine), not literally inside the <a> itself - this project builds via `next export`, so a defaultExpanded panel serialises to static HTML at build time, and real <a> tags nested inside another <a> get split apart by the browser's HTML parser on load (site 3 passes defaultExpanded and would hit this on every page load). Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related complaints against
ArtistSupportLink(issue #747, building on #733):QuestionFeed.tsx's illustration-group credit and confirmed-artist credit,ArtistSection.tsx's Art-by line). The fourth call site (CardDetailedViewBody.tsx's metadata table) already relied on its row label and needed no change.<div>below the collapsed link+toggle row rather than as part of the same widget. It now nests inside that row's shell, so it reads as part of the button rather than a separate floating block, across all four call sites (includingArtistSection.tsx'sdefaultExpandedcase).The panel nests inside the row's flex shell rather than literally inside the
<a>element: this project builds vianext export, so adefaultExpandedpanel is serialised to static HTML at build time, and real anchor tags nested inside another anchor get split apart by the browser's HTML parser on load - which would have broken call site 3's always-expanded case on every page load.Test plan
npm run build(frontend/) - compiles cleanly, no new TypeScript/ESLint errorsnpm test(frontend/) - 73 suites / 676 tests pass, includingArtistSupportLink.test.tsxnpx playwright test tests/QuestionFeed.spec.ts(chromium, standalone) - 28/28 passnpx playwright test tests/QuestionFeedResponsive.spec.ts(chromium, standalone) - 26/26 passnpx playwright test tests/ArtistSupportLink.spec.ts(chromium, standalone) - 2/2 passnpx playwright test tests/DisplayPage.spec.ts(chromium, standalone) - 32/33 pass; snip the one failure (display-empty-statetimeout in an unrelated phone-viewport scroll test) reproduces identically on a cleanorigin/mastercheckout, confirmed pre-existing