Render Keyrune set-symbol glyphs in the "What's That Card?" printing frames - #15
Merged
Merged
Conversation
…frames PrintingTagPicker and PrintingTagQueue showed bare expansion codes as plain text - the Keyrune integration added for CanonicalCardFilter's printing dropdown was never extended here. Adds a small SetIcon component using real <i class="ss ss-<code>"> markup (Keyrune's own classes, already loaded via _document.tsx) rather than the embedded-PUA-character trick CanonicalCardFilter needs for its plain-string-label-constrained dropdown library - no such constraint applies to this plain JSX, so the idiomatic Keyrune markup works directly. An expansion code Keyrune doesn't recognise falls back to its default glyph automatically, matching CanonicalCardFilter's existing fallback behavior. Verified: tsc, eslint, and a full production build are clean; a throwaway Playwright screenshot (not committed) confirmed the glyph renders as a real vector icon, not tofu; the existing PrintingTagQueue/PrintingTagPicker/VoteQueue Playwright specs pass (2 pre-existing PrintingTagPicker failures confirmed unrelated by reproducing them with these changes stashed out). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hfe2ccmc67RXotYNbMxKzr
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PrintingTagPickerandPrintingTagQueue(the "What's That Card?" quick-tag row and full vote queue) showed bare expansion codes as plain text - the Keyrune set-symbol icon integration added forCanonicalCardFilter's printing dropdown was never extended here.Adds
frontend/src/components/SetIcon.tsx, a small component using real<i class="ss ss-<code>">markup (Keyrune's own classes, already loaded globally via_document.tsx) rather than the embedded-PUA-character trickCanonicalCardFilterneeds for its plain-string-label-constrained dropdown library - no such constraint applies to this plain JSX, so the idiomatic Keyrune markup works directly. An expansion code Keyrune doesn't recognise falls back to its default glyph automatically, matchingCanonicalCardFilter's existing fallback behavior.Wired into all 4 set-code display sites across both files (candidate grid + consensus line, both components).
Rebased twice onto
masterwhile in flight (through PR #12/#13, then PR #14) since both landed changes toPrintingTagQueue.tsxand its dependencies concurrently - diff confirmed unchanged and re-verified after each rebase.Checklist
pre-commitand installed the hooks withpre-commit installbefore creating any commits.PrintingTagQueue/PrintingTagPicker/VoteQueue/NoMatchReasonStrip/PrintingConfirmStripPlaywright specs all still pass unmodified.tsc --noEmit, ESLint, and a full production build are clean.abc/xyzcodes).PrintingTagQueue,PrintingTagPicker,VoteQueue,NoMatchReasonStrip,PrintingConfirmStripspecs (15/15 passing; 2 pre-existingPrintingTagPickerfailures unrelated to this change, confirmed by reproducing them identically with these changes stashed out).CanonicalCardFilter.Generated by Claude Code