Render the Keyrune set-symbol glyph in the card-details "Canonical Card" row - #17
Merged
Merged
Conversation
…rd" row CardDetailedViewModal's "Canonical Card" row (shown when clicking a card image) had the same gap as PrintingTagPicker/PrintingTagQueue before this branch's earlier fix: expansion code rendered as bare text, no Keyrune glyph. AutofillTable's row values accept a React.ReactElement, so this uses the same SetIcon component directly rather than a plain string. Verified: tsc, eslint, and a full production build are clean. The GridSelectorModal Playwright suite (including its CanonicalCardFilter presence/absence tests) passes 23/23, confirming no regression. Could not get a direct screenshot of this specific modal in this sandbox - the same pre-existing "Card Details" modal-opening timeout that already affects PrintingTagPicker and TagVotePicker specs (unrelated to any change on this branch, reproduced deterministically and in isolation) blocks it here too. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hfe2ccmc67RXotYNbMxKzr
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #15.
CardDetailedViewModal's "Canonical Card" row (shown in the modal opened by clicking a card image) had the same gap asPrintingTagPicker/PrintingTagQueuebefore that PR: the expansion code rendered as bare text with no Keyrune glyph - found while confirming with the reporter whether the printing-tag frame fix would surface elsewhere once canonical card data is populated.AutofillTable's row values accept aReact.ReactElement, so this uses the sameSetIconcomponent directly (<i class="ss ss-<code>">) rather than a plain string, same pattern as #15.Checklist
pre-commitand installed the hooks withpre-commit installbefore creating any commits.tsc --noEmit, ESLint, and a full production build are clean.GridSelectorModalPlaywright suite passes 23/23, including itsCanonicalCardFilterpresence/absence tests - confirms no regression to the data-gated rendering this depends on.masterbefore this change too - also affectsPrintingTagPicker.spec.tsandTagVotePicker.spec.ts, neither of which this PR touches) blocks driving this exact click-to-open flow here. Root cause is environmental to this sandbox, not a regression from this change.Generated by Claude Code