Skip to content

admin/ui: never let table cells wrap and grow rows #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benben merged 1 commit into from
Jul 3, 2026
+6 −2
Merged

admin/ui: never let table cells wrap and grow rows #887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions controlplane/admin/ui/src/components/ui/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const TableHead = React.forwardRef<HTMLTableCellElement, React.ThHTMLAttributes<
<th
ref={ref}
className={cn(
"h-9 px-3 text-left align-middle text-xs font-medium uppercase tracking-wide text-muted-foreground [&:has([role=checkbox])]:pr-0",
"h-9 whitespace-nowrap px-3 text-left align-middle text-xs font-medium uppercase tracking-wide text-muted-foreground [&:has([role=checkbox])]:pr-0",
className,
)}
{...props}
Expand All @@ -51,7 +51,11 @@ TableHead.displayName = "TableHead";

const TableCell = React.forwardRef<HTMLTableCellElement, React.TdHTMLAttributes<HTMLTableCellElement>>(
({ className, ...props }, ref) => (
<td ref={ref} className={cn("px-3 py-2 align-middle", className)} {...props} />
// whitespace-nowrap: cell content (UUIDs, hostnames, timestamps) must never
// wrap and grow the row — the Table wrapper is overflow-auto, so wide
// content horizontal-scrolls instead. Override per-cell via className when
// a column genuinely needs to wrap.
<td ref={ref} className={cn("whitespace-nowrap px-3 py-2 align-middle", className)} {...props} />
),
);
TableCell.displayName = "TableCell";
Expand Down
Loading