admin/ui: never let table cells wrap and grow rows#887
Merged
Conversation
whitespace-nowrap on the base TableCell/TableHead primitives so long content (UUIDs, hostnames, timestamps) can never line-break and inflate row height in any table. The Table wrapper is overflow-auto, so wide content horizontal-scrolls instead. Per-cell className can still opt a column back into wrapping.
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Org rows (and potentially any table) grew tall when long values like UUIDs line-wrapped inside a cell.
Fix at the single chokepoint:
whitespace-nowrapon the baseTableCell/TableHeadprimitives inui/table.tsx. Every table in the admin UI (DataTable-backed and raw) renders through these, so no cell can ever wrap and inflate row height again. TheTablewrapper is alreadyoverflow-auto, so oversized content degrades to horizontal scroll instead of taller rows. A column that genuinely needs wrapping can still opt back in viaclassName.Frontend-only, one file. Verified with
npm run buildand eyeballed against prod data via the dev proxy (Orgs UUIDs back to one line, dense rows).🤖 Generated with Claude Code