Repository navigation
Conversation
|
LGTM |
anmvc
approved these changes
Oct 25, 2026
|
WHY can i review when im not matainer lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type of change
summary
fixes three items from #776:
§formatting codes now apply to all text, not just chat. vanilla's font decomposes them in everything it draws, so titles, subtitles, boss bars, the scoreboard, item names, the tab list and container titles showed the raw codes. chat still strips them first when chat colors is off.onlineMode); offline servers get no head column at all.DebugEntryPosition, instead of counting past 359.reference
net/minecraft/client/gui/components/PlayerTabOverlay.java,client/gui/components/debug/DebugEntryPosition.java,util/StringDecomposer.java,client/gui/components/ComponentRenderUtils.javatesting
unit tests for the facing line and legacy code decomposition.
just ingame-test33/33. in game against a local offline server: title, subtitle, sidebar, boss bar and item name all render§codes with no raw codes left, and the tab list has no head column. online-mode heads need a real server.