Make rrbot demo an independent package - #27
Open
zultron wants to merge 5 commits into
Open
Conversation
- Use catkin `add_compile_options` instead of setting `CMAKE_CXX_FLAGS` - Don't `find_package(Gflags)`; this is now standard in ROS installs - Alphabetize lists Now passes `catkin lint -W2 src/ros_control_boilerplate` without warnings or problems.
For the rrbot_control_boilerplate directory to be discovered, get this out of the way
There is already an `rrbot_control` package from the `gazebo_ros_demos` repo[1]. Give this package a unique name to resolve conflicts. [1]: https://github.com/ros-simulation/gazebo_ros_demos
The `rrbot_control_boilerplate` package is now a real, independent package. Other packages can now build against it from CMake with `find_package(rrbot_control_boilerplate)`, and `.launch` files can include its `.launch` files and load its configuration files.
zultron
added a commit
to tormach/hal_ros_control
that referenced
this pull request
Jan 28, 2019
Update the rrbot demo to work with changes from PickNikRobotics/ros_control_boilerplate#27: update `rrbot_control_boilerplate` name, and reuse its configuration and launch configuration files.
davetcoleman
approved these changes
Jul 14, 2020
davetcoleman
left a comment
davetcoleman
left a comment
Member
There was a problem hiding this comment.
A lot of good changes here! @AndyZe what are your thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the rrbot demo install an independent package that can be referenced from other packages. My use case is to reuse rrbot files in the
hal_ros_controlrrbot demo: that hardware interface subclasses this one, and that demo reuses launch and configuration files from this one.This PR tweaks a few other things: fixes
catkin lintwarnings, updates URLs inpackage.xmlfiles, drops the redundantFindGflags.cmakescript.