Repository navigation
Repo - BUGFIX - Name the GPEC version that wrote a gpec.h5 and the ways forward when it cannot be replayed - #642
Merged
Conversation
…ys forward when it cannot be replayed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186CLfjeJeSusNTva5RMfGU
matt-pharr
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
When GPEC cannot replay a
gpec.h5, orequilibrium_from_h5cannot restore one, the error now says which GPEC version wrote the file and which version is running, and gives two ways forward. The first is to check out the version that wrote the file (the commit comes fromInfo/git_version). The second is to run the file's stored deck with the current version, using a copy-paste command that writes the deck out. Before, the error said only "re-run from the original deck", which assumed the user still had the deck and did not say which version would replay the file.Changes
Rerun.jl):rlar_flag), because whoever runs the stored deck needs it.git describeis read in one helper,_gpec_git_version, which replaces the two copies of that code.Example:
Tests
unknown) maps to the right thing to check out.Regression report
Pending: queued on feynman. This change touches only error text, so no tracked quantity can move. I will post the report and update the stamp when the run finishes.
Notes for reviewers
<stem>_kinetic.h5,_wall.dat,_forcing.h5and_tolerances.tomlnext to its output. Removing them, so that one run writes one file, is a separate change.🤖 Generated with Claude Code
https://claude.ai/code/session_0186CLfjeJeSusNTva5RMfGU